Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Hydra 1.3.2 #85

Open
dxoigmn opened this issue Feb 23, 2023 · 0 comments
Open

Upgrade to Hydra 1.3.2 #85

dxoigmn opened this issue Feb 23, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dxoigmn
Copy link
Contributor

dxoigmn commented Feb 23, 2023

I think this will enable MART to get rid of DotDict:

MART/mart/nn/nn.py

Line 162 in 422978c

class DotDict(dict):

by hydra.utils.get_object in Hydra 1.3.2:

https://github.com/facebookresearch/hydra/blob/2b5cb67edb88161d6dc4b62f90e867bcda68fe00/hydra/utils.py#L70
@dxoigmn dxoigmn added enhancement New feature or request good first issue Good for newcomers labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dxoigmn