Skip to content

Consider new ways to call CMake #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PokhodenkoSA opened this issue Nov 12, 2020 · 2 comments
Closed

Consider new ways to call CMake #173

PokhodenkoSA opened this issue Nov 12, 2020 · 2 comments
Assignees
@oleksandr-pavlyk
Labels
infrastructure

Comments

@PokhodenkoSA
Copy link
Contributor

I thought this PR would build on Python's interface to CMake:

https://github.com/pytorch/pytorch/blob/master/tools/build_pytorch_libs.py#L51

Kind of like

https://github.com/pytorch/pytorch/blob/master/tools/setup_helpers/cmake.py#L94

Maybe a little too heavy-handed for our purposes.

Originally posted by @oleksandr-pavlyk in #168 (comment)
@diptorupd
Copy link
Contributor

@oleksandr-pavlyk I think you latest design using scikit-build will subsume this ticket. I am assigning it to you for that reason.

@diptorupd
Copy link
Contributor

Closing as we now use skbuild to invoke Cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleksandr-pavlyk oleksandr-pavlyk

Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PokhodenkoSA @diptorupd @oleksandr-pavlyk