Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception handling inside libsyclinterface #351

Closed
diptorupd opened this issue Apr 1, 2021 · 1 comment
Closed

Improve exception handling inside libsyclinterface #351

diptorupd opened this issue Apr 1, 2021 · 1 comment
Labels
libsyclinterface Issues related to libsyclinterface

Comments

@diptorupd
Copy link
Contributor

diptorupd commented Apr 1, 2021 •
edited
Loading

Please, do catch(...) finally. Any uncatched exception will break C API interface.

Originally posted by @PokhodenkoSA in #349 (comment)

Related to #35
@diptorupd diptorupd mentioned this issue Nov 18, 2021
Closed
1 task
@diptorupd diptorupd changed the title Improve exception handling inside dpctl-capi. Improve exception handling inside libsyclinterface Jan 8, 2022
@diptorupd diptorupd added the libsyclinterface Issues related to libsyclinterface label Jan 8, 2022
@diptorupd
Copy link
Contributor Author

I prefer to treat any uncaught exception as a bug and fix it rather than use the catch(...) functionality. Doing so will allow us to provide more useful error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libsyclinterface Issues related to libsyclinterface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diptorupd