Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix queue creation with an invalid property #494

Closed
diptorupd opened this issue Jun 23, 2021 · 1 comment · Fixed by #535
Closed

Fix queue creation with an invalid property #494

diptorupd opened this issue Jun 23, 2021 · 1 comment · Fixed by #535
Assignees
@diptorupd

Comments

@diptorupd
Copy link
Contributor

The C API function DPCTLQueue_Create allows creating a queue even when the property is invalid. The invalid property is silently ignored and the queue is created without warning the user. Either we should print a warning or prevent queue creation when the property is invalid.
@diptorupd diptorupd self-assigned this Jun 23, 2021
oleksandr-pavlyk added a commit that referenced this issue Aug 18, 2021
@oleksandr-pavlyk
Addressed concern regarding #494
cecde73 
Added logic to verify that all bits of property integer were
recognized and used.

Added test to verify handling of property bits.
@oleksandr-pavlyk oleksandr-pavlyk mentioned this issue Aug 18, 2021
Merged
@oleksandr-pavlyk
Copy link
Collaborator

Addressed in #535

oleksandr-pavlyk added a commit that referenced this issue Aug 19, 2021
@oleksandr-pavlyk
Merge pull request #535 from IntelPython/bugfix/gh-494
0f96cb7 
Addressed concern regarding #494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diptorupd diptorupd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addressed concern regarding #494 IntelPython/dpctl
2 participants
@diptorupd @oleksandr-pavlyk