Change dtype check in dpnp.asfarray and fix remarks

Author: vlad-perevezentsev

dpnp/dpnp_iface_manipulation.py

@@ -48,6 +48,7 @@
 
 import dpnp
 import numpy
+import numpy.core.numeric as _nx
 
 
 __all__ = [
@@ -82,15 +83,15 @@ def asfarray(x1, dtype=None):
     Notes
     -----
     This function works exactly the same as :obj:`dpnp.array`.
+    If dtype is `None`, `bool` or one of the `int` dtypes, it is replaced with
+    the default floating type in DPNP depending on device capabilities.
 
     """
 
     x1_desc = dpnp.get_dpnp_descriptor(x1, copy_when_nondefault_queue=False)
     if x1_desc:
-        # int types replaced with a floating type by default in DPNP
-        # depending on device capabilities.
-        if dtype is None or numpy.issubdtype(dtype, numpy.integer):
-            dtype = dpnp.default_float_type()
+        if dtype is None or not numpy.issubdtype(dtype, _nx.inexact):
+            dtype = dpnp.default_float_type(sycl_queue=x1.sycl_queue)
 
         # if type is the same then same object should be returned
         if x1_desc.dtype == dtype:

tests/test_arraymanipulation.py

@@ -6,7 +6,7 @@
 
 
 @pytest.mark.usefixtures("allow_fall_back_on_numpy")
-@pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True))
+@pytest.mark.parametrize("dtype", get_all_dtypes())
 @pytest.mark.parametrize(
     "data", [[1, 2, 3], [1.0, 2.0, 3.0]], ids=["[1, 2, 3]", "[1., 2., 3.]"]
 )
@@ -17,13 +17,12 @@ def test_asfarray(dtype, data):
     numpy.testing.assert_array_equal(result, expected)
 
 
-@pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True))
-@pytest.mark.parametrize(
-    "data", [[1, 2, 3], [1.0, 2.0, 3.0]], ids=["[1, 2, 3]", "[1., 2., 3.]"]
-)
-def test_asfarray2(dtype, data):
-    expected = numpy.asfarray(numpy.array(data), dtype)
-    result = dpnp.asfarray(dpnp.array(data), dtype)
+@pytest.mark.parametrize("dtype", get_all_dtypes())
+@pytest.mark.parametrize("data", [[1.0, 2.0, 3.0]], ids=["[1., 2., 3.]"])
+@pytest.mark.parametrize("data_dtype", get_all_dtypes(no_none=True))
+def test_asfarray2(dtype, data, data_dtype):
+    expected = numpy.asfarray(numpy.array(data, dtype=data_dtype), dtype)
+    result = dpnp.asfarray(dpnp.array(data, dtype=data_dtype), dtype)
 
     numpy.testing.assert_array_equal(result, expected)