Small improvements.

   - Move the union for bit-casting into the DPEXRT_MemInfo_fill
     function, as it is the only place it is used.
   - Use the union for bit conversions for all case to make the
     code easier to follow.
   - Changes to numba_dpex.dpnp_iface._intrinsic.fill_arrayobj:
      - Ensure a bitcast is added by unconditionally and not just
        for floats.
      - Change assignment of value_is_float and dest_is_float objects
        to if-else statements, otherwise we will have two constants
	in the LLVM IR whene the type is a Float.

Author: Diptorup Deb

numba_dpex/core/runtime/_dpexrt_python.c

@@ -23,26 +23,6 @@
 #include "_queuestruct.h"
 #include "numba/_arraystruct.h"
 
-/**
- * @brief A union for bit representations of float.
- * This is useful in DPEXRT_MemInfo_fill() function.
- */
-typedef union
-{
-    float f_;    /**< The float to be represented. */
-    uint32_t i_; /**< The bit representation. */
-} float_uint32_t;
-
-/**
- * @brief A union for bit representations of double.
- * This is useful in DPEXRT_MemInfo_fill() function.
- */
-typedef union
-{
-    double d_;   /**< The double to be represented. */
-    uint64_t i_; /**< The bit representation. */
-} double_uint64_t;
-
 // forward declarations
 static struct PyUSMArrayObject *PyUSMNdArray_ARRAYOBJ(PyObject *obj);
 static npy_intp product_of_shape(npy_intp *shape, npy_intp ndim);
@@ -557,6 +537,26 @@ static NRT_MemInfo *DPEXRT_MemInfo_fill(NRT_MemInfo *mi,
     DPCTLSyclEventRef eref = NULL;
     size_t count = 0, size = 0, exp = 0;
 
+    /**
+     * @brief A union for bit conversion from the input int64_t value
+     * to a uintX_t bit-pattern with appropriate type conversion when the
+     * input value represents a float.
+     */
+    typedef union
+    {
+        float f_; /**< The float to be represented. */
+        double d_;
+        int8_t i8_;
+        int16_t i16_;
+        int32_t i32_;
+        int64_t i64_;
+        uint8_t ui8_;
+        uint16_t ui16_;
+        uint32_t ui32_; /**< The bit representation. */
+        uint64_t ui64_; /**< The bit representation. */
+    } bitcaster_t;
+
+    bitcaster_t bc;
     size = mi->size;
     while (itemsize >>= 1)
         exp++;
@@ -580,77 +580,83 @@ static NRT_MemInfo *DPEXRT_MemInfo_fill(NRT_MemInfo *mi,
     switch (exp) {
     case 3:
     {
-        int64_t value_assign = (int64_t)value;
         if (dest_is_float && value_is_float) {
-            double_uint64_t du;
             double *p = (double *)(&value);
-            du.d_ = *p;
-            value_assign = du.i_;
+            bc.d_ = *p;
         }
         else if (dest_is_float && !value_is_float) {
-            double_uint64_t du;
             // To stop warning: dereferencing type-punned pointer
             // will break strict-aliasing rules [-Wstrict-aliasing]
             double cd = (double)value;
-            du.d_ = *((double *)(&cd));
-            value_assign = du.i_;
+            bc.d_ = *((double *)(&cd));
         }
         else if (!dest_is_float && value_is_float) {
             double *p = (double *)&value;
-            value_assign = *p;
+            bc.i64_ = *p;
+        }
+        else {
+            bc.i64_ = value;
         }
-        if (!(eref = DPCTLQueue_Fill64(qref, mi->data, value_assign, count)))
+
+        if (!(eref = DPCTLQueue_Fill64(qref, mi->data, bc.ui64_, count)))
             goto error;
         break;
     }
     case 2:
     {
-        int32_t value_assign = (int32_t)value;
         if (dest_is_float && value_is_float) {
-            float_uint32_t fu;
             double *p = (double *)(&value);
-            fu.f_ = *p;
-            value_assign = fu.i_;
+            bc.f_ = *p;
         }
         else if (dest_is_float && !value_is_float) {
-            float_uint32_t fu;
             // To stop warning: dereferencing type-punned pointer
             // will break strict-aliasing rules [-Wstrict-aliasing]
             float cf = (float)value;
-            fu.f_ = *((float *)(&cf));
-            value_assign = fu.i_;
+            bc.f_ = *((float *)(&cf));
         }
         else if (!dest_is_float && value_is_float) {
             double *p = (double *)&value;
-            value_assign = *p;
+            bc.i32_ = *p;
+        }
+        else {
+            bc.i32_ = (int32_t)value;
         }
-        if (!(eref = DPCTLQueue_Fill32(qref, mi->data, value_assign, count)))
+
+        if (!(eref = DPCTLQueue_Fill32(qref, mi->data, bc.ui32_, count)))
             goto error;
         break;
     }
     case 1:
     {
         if (dest_is_float)
             goto error;
-        int16_t value_assign = (int16_t)value;
+
         if (value_is_float) {
             double *p = (double *)&value;
-            value_assign = *p;
+            bc.i16_ = *p;
+        }
+        else {
+            bc.i16_ = (int16_t)value;
         }
-        if (!(eref = DPCTLQueue_Fill16(qref, mi->data, value_assign, count)))
+
+        if (!(eref = DPCTLQueue_Fill16(qref, mi->data, bc.ui16_, count)))
             goto error;
         break;
     }
     case 0:
     {
         if (dest_is_float)
             goto error;
-        int8_t value_assign = (int8_t)value;
+
         if (value_is_float) {
             double *p = (double *)&value;
-            value_assign = *p;
+            bc.i8_ = *p;
         }
-        if (!(eref = DPCTLQueue_Fill8(qref, mi->data, value_assign, count)))
+        else {
+            bc.i8_ = (int8_t)value;
+        }
+
+        if (!(eref = DPCTLQueue_Fill8(qref, mi->data, bc.ui8_, count)))
             goto error;
         break;
     }

numba_dpex/dpnp_iface/_intrinsic.py

@@ -78,14 +78,18 @@ def fill_arrayobj(context, builder, sig, llargs, value, is_like=False):
     )
     device = context.insert_const_string(builder.module, arrtype[0].device)
 
-    value_is_float = context.get_constant(types.boolean, 0)
+    # Do a bitcast of the input to a 64-bit int.
+    value = builder.bitcast(value, llvmir.IntType(64))
+
     if isinstance(sig.args[1], types.scalars.Float):
-        value = builder.bitcast(value, llvmir.IntType(64))
         value_is_float = context.get_constant(types.boolean, 1)
+    else:
+        value_is_float = context.get_constant(types.boolean, 0)
 
-    dest_is_float = context.get_constant(types.boolean, 0)
     if isinstance(arrtype[0].dtype, types.scalars.Float):
         dest_is_float = context.get_constant(types.boolean, 1)
+    else:
+        dest_is_float = context.get_constant(types.boolean, 0)
 
     dpexrtCtx = dpexrt.DpexRTContext(context)
     dpexrtCtx.meminfo_fill(