Skip to content

Commit 5712ef4

Browse files
committed
Remove unused parfor kernel IR methods
1 parent 8f8b98c commit 5712ef4

File tree

3 files changed

+6
-62
lines changed

3 files changed

+6
-62
lines changed

numba_dpex/core/parfors/kernel_templates/kernel_template_iface.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,6 @@ def _generate_kernel_ir(self):
3030
def dump_kernel_string(self):
3131
raise NotImplementedError
3232

33-
@abc.abstractmethod
34-
def dump_kernel_ir(self):
35-
raise NotImplementedError
36-
37-
@property
38-
@abc.abstractmethod
39-
def kernel_ir(self):
40-
raise NotImplementedError
41-
4233
@property
4334
@abc.abstractmethod
4435
def kernel_string(self):

numba_dpex/core/parfors/kernel_templates/range_kernel_template.py

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def __init__(
5050
self._param_dict = param_dict
5151

5252
self._kernel_txt = self._generate_kernel_stub_as_string()
53-
self._py_func, self._kernel_ir = self._generate_kernel_ir()
53+
self._py_func = self._generate_kernel_ir()
5454

5555
def _generate_kernel_stub_as_string(self):
5656
"""Generates a stub dpex kernel for the parfor as a string.
@@ -108,17 +108,7 @@ def _generate_kernel_ir(self):
108108
globls = {"dpnp": dpnp, "dpex": dpex}
109109
locls = {}
110110
exec(self._kernel_txt, globls, locls)
111-
kernel_fn = locls[self._kernel_name]
112-
113-
return kernel_fn, None
114-
115-
@property
116-
def kernel_ir(self):
117-
"""Returns the Numba IR generated for a RangeKernelTemplate.
118-
119-
Returns: The Numba functionIR object for the compiled kernel_txt string.
120-
"""
121-
return self._kernel_ir
111+
return locls[self._kernel_name]
122112

123113
@property
124114
def kernel_string(self):
@@ -133,7 +123,3 @@ def dump_kernel_string(self):
133123
"""Helper to print the kernel function string."""
134124
print(self._kernel_txt)
135125
sys.stdout.flush()
136-
137-
def dump_kernel_ir(self):
138-
"""Helper to dump the Numba IR for the RangeKernelTemplate."""
139-
self._kernel_ir.dump()

numba_dpex/core/parfors/kernel_templates/reduction_template.py

Lines changed: 4 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def __init__(
4747
self._typemap = typemap
4848

4949
self._kernel_txt = self._generate_kernel_stub_as_string()
50-
self._py_func, self._kernel_ir = self._generate_kernel_ir()
50+
self._py_func = self._generate_kernel_ir()
5151

5252
def _generate_kernel_stub_as_string(self):
5353
"""Generate reduction main kernel template"""
@@ -160,18 +160,7 @@ def _generate_kernel_ir(self):
160160
globls = {"dpnp": dpnp, "kapi": kapi}
161161
locls = {}
162162
exec(self._kernel_txt, globls, locls)
163-
kernel_fn = locls[self._kernel_name]
164-
165-
return kernel_fn, None
166-
167-
@property
168-
def kernel_ir(self):
169-
"""Returns the Numba IR generated for a
170-
TreeReduceIntermediateKernelTemplate.
171-
172-
Returns: The Numba functionIR object for the compiled kernel_txt string.
173-
"""
174-
return self._kernel_ir
163+
return locls[self._kernel_name]
175164

176165
@property
177166
def kernel_string(self):
@@ -189,11 +178,6 @@ def dump_kernel_string(self):
189178
print(self._kernel_txt)
190179
sys.stdout.flush()
191180

192-
def dump_kernel_ir(self):
193-
"""Helper to dump the Numba IR for a
194-
TreeReduceIntermediateKernelTemplate."""
195-
self._kernel_ir.dump()
196-
197181

198182
class RemainderReduceIntermediateKernelTemplate(KernelTemplateInterface):
199183
"""The class to build reduction remainder kernel_txt template and
@@ -233,7 +217,7 @@ def __init__(
233217
self._reductionKernelVar = reductionKernelVar
234218

235219
self._kernel_txt = self._generate_kernel_stub_as_string()
236-
self._py_func, self._kernel_ir = self._generate_kernel_ir()
220+
self._py_func = self._generate_kernel_ir()
237221

238222
def _generate_kernel_stub_as_string(self):
239223
"""Generate reduction remainder kernel template"""
@@ -319,18 +303,7 @@ def _generate_kernel_ir(self):
319303
globls = {"dpnp": dpnp, "kapi": kapi}
320304
locls = {}
321305
exec(self._kernel_txt, globls, locls)
322-
kernel_fn = locls[self._kernel_name]
323-
324-
return kernel_fn, None
325-
326-
@property
327-
def kernel_ir(self):
328-
"""Returns the Numba IR generated for a
329-
RemainderReduceIntermediateKernelTemplate.
330-
331-
Returns: The Numba functionIR object for the compiled kernel_txt string.
332-
"""
333-
return self._kernel_ir
306+
return locls[self._kernel_name]
334307

335308
@property
336309
def kernel_string(self):
@@ -348,9 +321,3 @@ def dump_kernel_string(self):
348321

349322
print(self._kernel_txt)
350323
sys.stdout.flush()
351-
352-
def dump_kernel_ir(self):
353-
"""Helper to dump the Numba IR for the
354-
RemainderReduceIntermediateKernelTemplate."""
355-
356-
self._kernel_ir.dump()

0 commit comments

Comments
 (0)