Skip to content

Commit c0dd04f

Browse files
author
Diptorup Deb
authored
Merge pull request #1043 from IntelPython/remove_like
Removed like arg in dpnp empty, zeros and ones overload.
2 parents 5c18691 + f7b2e49 commit c0dd04f

File tree

2 files changed

+0
-37
lines changed

2 files changed

+0
-37
lines changed

numba_dpex/dpnp_iface/_intrinsic.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ def impl_dpnp_empty(
127127
ty_shape,
128128
ty_dtype,
129129
ty_order,
130-
# ty_like, # see issue https://github.com/IntelPython/numba-dpex/issues/998
131130
ty_device,
132131
ty_usm_type,
133132
ty_sycl_queue,
@@ -145,7 +144,6 @@ def impl_dpnp_empty(
145144
dtype.
146145
ty_order (numba.core.types.misc.UnicodeType): UnicodeType
147146
from numba for strings.
148-
ty_like (numba.core.types.npytypes.Array): Numba type for array.
149147
ty_device (numba.core.types.misc.UnicodeType): UnicodeType
150148
from numba for strings.
151149
ty_usm_type (numba.core.types.misc.UnicodeType): UnicodeType
@@ -165,7 +163,6 @@ def impl_dpnp_empty(
165163
ty_shape,
166164
ty_dtype,
167165
ty_order,
168-
# ty_like, # see issue https://github.com/IntelPython/numba-dpex/issues/998
169166
ty_device,
170167
ty_usm_type,
171168
ty_sycl_queue,
@@ -185,7 +182,6 @@ def impl_dpnp_zeros(
185182
ty_shape,
186183
ty_dtype,
187184
ty_order,
188-
ty_like,
189185
ty_device,
190186
ty_usm_type,
191187
ty_sycl_queue,
@@ -203,7 +199,6 @@ def impl_dpnp_zeros(
203199
dtype.
204200
ty_order (numba.core.types.misc.UnicodeType): UnicodeType
205201
from numba for strings.
206-
ty_like (numba.core.types.npytypes.Array): Numba type for array.
207202
ty_device (numba.core.types.misc.UnicodeType): UnicodeType
208203
from numba for strings.
209204
ty_usm_type (numba.core.types.misc.UnicodeType): UnicodeType
@@ -223,7 +218,6 @@ def impl_dpnp_zeros(
223218
ty_shape,
224219
ty_dtype,
225220
ty_order,
226-
ty_like,
227221
ty_device,
228222
ty_usm_type,
229223
ty_sycl_queue,
@@ -245,7 +239,6 @@ def impl_dpnp_ones(
245239
ty_shape,
246240
ty_dtype,
247241
ty_order,
248-
ty_like,
249242
ty_device,
250243
ty_usm_type,
251244
ty_sycl_queue,
@@ -263,7 +256,6 @@ def impl_dpnp_ones(
263256
dtype.
264257
ty_order (numba.core.types.misc.UnicodeType): UnicodeType
265258
from numba for strings.
266-
ty_like (numba.core.types.npytypes.Array): Numba type for array.
267259
ty_device (numba.core.types.misc.UnicodeType): UnicodeType
268260
from numba for strings.
269261
ty_usm_type (numba.core.types.misc.UnicodeType): UnicodeType
@@ -283,7 +275,6 @@ def impl_dpnp_ones(
283275
ty_shape,
284276
ty_dtype,
285277
ty_order,
286-
ty_like,
287278
ty_device,
288279
ty_usm_type,
289280
ty_sycl_queue,

numba_dpex/dpnp_iface/arrayobj.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,6 @@ def ol_dpnp_empty(
210210
shape,
211211
dtype=None,
212212
order="C",
213-
# like=None, # this gets lost when dpnp.empty() is called outside dpjit,
214-
# see issue https://github.com/IntelPython/numba-dpex/issues/998
215213
device=None,
216214
usm_type="device",
217215
sycl_queue=None,
@@ -229,12 +227,6 @@ def ol_dpnp_empty(
229227
Default: None.
230228
order (str, optional): memory layout for the array "C" or "F".
231229
Default: "C".
232-
like (numba.core.types.npytypes.Array, optional): A type for
233-
reference object to allow the creation of arrays which are not
234-
`NumPy` arrays. If an array-like passed in as `like` supports the
235-
`__array_function__` protocol, the result will be defined by it.
236-
In this case, it ensures the creation of an array object
237-
compatible with that passed in via this argument.
238230
device (numba.core.types.misc.StringLiteral, optional): array API
239231
concept of device where the output array is created. `device`
240232
can be `None`, a oneAPI filter selector string, an instance of
@@ -278,7 +270,6 @@ def impl(
278270
shape,
279271
dtype=None,
280272
order="C",
281-
# like=None, see issue https://github.com/IntelPython/numba-dpex/issues/998
282273
device=None,
283274
usm_type="device",
284275
sycl_queue=None,
@@ -287,7 +278,6 @@ def impl(
287278
shape,
288279
_dtype,
289280
order,
290-
# like, see issue https://github.com/IntelPython/numba-dpex/issues/998
291281
_device,
292282
_usm_type,
293283
sycl_queue,
@@ -309,7 +299,6 @@ def ol_dpnp_zeros(
309299
shape,
310300
dtype=None,
311301
order="C",
312-
like=None,
313302
device=None,
314303
usm_type="device",
315304
sycl_queue=None,
@@ -327,12 +316,6 @@ def ol_dpnp_zeros(
327316
Default: None.
328317
order (str, optional): memory layout for the array "C" or "F".
329318
Default: "C".
330-
like (numba.core.types.npytypes.Array, optional): A type for
331-
reference object to allow the creation of arrays which are not
332-
`NumPy` arrays. If an array-like passed in as `like` supports the
333-
`__array_function__` protocol, the result will be defined by it.
334-
In this case, it ensures the creation of an array object
335-
compatible with that passed in via this argument.
336319
device (numba.core.types.misc.StringLiteral, optional): array API
337320
concept of device where the output array is created. `device`
338321
can be `None`, a oneAPI filter selector string, an instance of
@@ -376,7 +359,6 @@ def impl(
376359
shape,
377360
dtype=None,
378361
order="C",
379-
like=None,
380362
device=None,
381363
usm_type="device",
382364
sycl_queue=None,
@@ -385,7 +367,6 @@ def impl(
385367
shape,
386368
_dtype,
387369
order,
388-
like,
389370
_device,
390371
_usm_type,
391372
sycl_queue,
@@ -407,7 +388,6 @@ def ol_dpnp_ones(
407388
shape,
408389
dtype=None,
409390
order="C",
410-
like=None,
411391
device=None,
412392
usm_type="device",
413393
sycl_queue=None,
@@ -425,12 +405,6 @@ def ol_dpnp_ones(
425405
Default: None.
426406
order (str, optional): memory layout for the array "C" or "F".
427407
Default: "C".
428-
like (numba.core.types.npytypes.Array, optional): A type for
429-
reference object to allow the creation of arrays which are not
430-
`NumPy` arrays. If an array-like passed in as `like` supports the
431-
`__array_function__` protocol, the result will be defined by it.
432-
In this case, it ensures the creation of an array object
433-
compatible with that passed in via this argument.
434408
device (numba.core.types.misc.StringLiteral, optional): array API
435409
concept of device where the output array is created. `device`
436410
can be `None`, a oneAPI filter selector string, an instance of
@@ -474,7 +448,6 @@ def impl(
474448
shape,
475449
dtype=None,
476450
order="C",
477-
like=None,
478451
device=None,
479452
usm_type="device",
480453
sycl_queue=None,
@@ -483,7 +456,6 @@ def impl(
483456
shape,
484457
_dtype,
485458
order,
486-
like,
487459
_device,
488460
_usm_type,
489461
sycl_queue,

0 commit comments

Comments
 (0)