Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement static_getitem for DpnpNdArray type #1086

Open
diptorupd opened this issue Jun 28, 2023 · 0 comments
Open

Implement static_getitem for DpnpNdArray type #1086

diptorupd opened this issue Jun 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@diptorupd
Copy link
Contributor

An implementation for the static_getitem function for DpnpNdArray is missing and that results in the lowering falling back to the generic lower_getitem that in turn resolves to the getitem_arraynd_intp call defined in numba/np/arrayobj.py.

In current main using Numba's function for DpnpNdArray works fine as the underlying data model for DpnpNdArray is the same as types.Array. However, with the changes introduced in #1083 the approach fails. Hence, we need a DpnpNdArray-specific implementation of getitem.

@diptorupd diptorupd self-assigned this Jun 28, 2023
@diptorupd diptorupd added the enhancement New feature or request label Dec 20, 2023
@diptorupd diptorupd removed their assignment Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant