Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - extend drep id cmd so that it returns id in hex and bech32 for script based dreps. Use CIP105 #883

Open
2 of 18 tasks
CarlosLopezDeLara opened this issue Sep 5, 2024 · 3 comments
Assignees
Labels
conway-feature intra-era-hardfork feature to be added for protocol version 10

Comments

@CarlosLopezDeLara
Copy link
Contributor

What

Extend cardano-cli conway drep id so that it returns drep id in hex and bech32 also for script based dreps.

We should use Use CIP105 so that the prefix for script based dreps should be drep_script

Why

Personas

  • DReps
  • SPOs
  • dApp Devs
  • Exchanges
  • Wallets
  • 3rd party tools
  • ADA holders

Definition of Done (DoD)

  • Acceptance Criteria + User Stories & DoD created and singed-off (by PO, dev & test owners)
  • Builds successfully on CI
  • Code & Test review (as per Acceptance Criteria)
  • There is documentation and/or examples for the new functionality (usage/response)
  • Log/record changes on Vnext (or similar depending on what we adopt)
  • Ticket number(s) included in PR description
  • All Acceptance Criteria met and covered by dev/unit/property/integration tests
  • System/E2E automated tests + System Test Engineer Owner Sign-off

NOTE: Ideally, we should merge only fully implemented and tested features into the master branch.
So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged
after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off
was not provided (last step in the DoD).

IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.

Sign-off

  • Product Owner
  • Dev Owner
  • System Test Engineer Owner

Related PRs

  1. PR # here

Acceptance Criteria

Acceptance Criteria & User Stories define here (or in a separate file (linked here) for a big feature)

Example - IntersectMBO/cardano-node#4453

@CarlosLopezDeLara CarlosLopezDeLara changed the title [FEATURE] - extend drep id so thet it return id in hex and bech32 for script based dreps. Use CIP105 [FEATURE] - extend drep id cmd so that it returns id in hex and bech32 for script based dreps. Use CIP105 Sep 5, 2024
@smelc
Copy link
Contributor

smelc commented Sep 6, 2024

@CarlosLopezDeLara> something we can work on together maybe?

@smelc smelc self-assigned this Sep 6, 2024
@CarlosLopezDeLara
Copy link
Contributor Author

Wait untill CIP129 or CIP105 is approved.

@CarlosLopezDeLara CarlosLopezDeLara added the intra-era-hardfork feature to be added for protocol version 10 label Sep 24, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Oct 27, 2024
@smelc smelc removed the Stale label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conway-feature intra-era-hardfork feature to be added for protocol version 10
Projects
None yet
Development

No branches or pull requests

2 participants