Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build cmd's calculate-plutus-script-cost doesn't include script hash for reference scripts #4094

Closed
catch-21 opened this issue Jun 24, 2022 · 1 comment · Fixed by #4204
Closed
Labels
comp: cardano-cli era: babbage in-scope This item is being worked and will be part of an upcoming release priority high issues/PRs that MUST be addressed. The release can't happen without this; priority: high Needs to be addressed as soon as possible, probably within current sprint. tag: 1.35.0-rc4 type: bug Something is not working user type: internal Created by an IOG employee Vasil

Comments

@catch-21
Copy link
Contributor

Internal/External
Internal if an IOHK staff member.

Area
Plutus Related to Plutus Scripts (Alonzo).

Summary
When using build cmd's --calculate-plutus-script-cost to produce an output of each plutus script's resource requirement and cost the scriptHash field is null for reference scripts. It is correctly populated for attached scrtips. See comparison of two transactions using the same script as reference and as attached:

$ cat ref_cost attached_cost
[
    {
        "executionUnits": {
            "memory": 663882,
            "steps": 205620764
        },
        "lovelaceCost": 53132,
        "scriptHash": null
    }
][
    {
        "executionUnits": {
            "memory": 570992,
            "steps": 176055294
        },
        "lovelaceCost": 45640,
        "scriptHash": "505755e49f9873b02258f1e6fdcc6c81446ab560a0e78180c600d9bd"
    }
]

Steps to reproduce
Steps to reproduce the behavior:

  1. Use cli's build cmd to construct a transaction using a plutus reference script, use --calculate-plutus-script-cost flag to produce an output file
  2. Read the output file

Expected behavior
scriptHash is always populated

System info (please complete the following information):
Node/CLI Version: 43393ac

@catch-21 catch-21 added bug Something isn't working Vasil labels Jun 24, 2022
@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Jun 24, 2022

Assess! impact to workflow

@CarlosLopezDeLara CarlosLopezDeLara added priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn priority high issues/PRs that MUST be addressed. The release can't happen without this; 1.35.1 Include in 1.35.1 and removed priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn labels Jun 29, 2022
@CarlosLopezDeLara CarlosLopezDeLara added 1.35.2 and removed 1.35.1 Include in 1.35.1 labels Jul 8, 2022
@Jimbo4350 Jimbo4350 changed the title [BUG] - build cmd's calculate-plutus-script-cost doesn't include script hash for reference scripts build cmd's calculate-plutus-script-cost doesn't include script hash for reference scripts Jul 20, 2022
@Jimbo4350 Jimbo4350 removed the bug Something isn't working label Jul 20, 2022
@CarlosLopezDeLara CarlosLopezDeLara added in-scope This item is being worked and will be part of an upcoming release and removed 1.35.2 labels Jul 22, 2022
@iohk-bors iohk-bors bot closed this as completed in a9bc2f9 Jul 28, 2022
@dorin100 dorin100 added type: bug Something is not working user type: internal Created by an IOG employee priority: high Needs to be addressed as soon as possible, probably within current sprint. era: babbage comp: cardano-cli tag: 1.35.0-rc4 labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: cardano-cli era: babbage in-scope This item is being worked and will be part of an upcoming release priority high issues/PRs that MUST be addressed. The release can't happen without this; priority: high Needs to be addressed as soon as possible, probably within current sprint. tag: 1.35.0-rc4 type: bug Something is not working user type: internal Created by an IOG employee Vasil
Projects
None yet
4 participants