Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical Debt #4300

Open
2 of 8 tasks
CarlosLopezDeLara opened this issue Aug 11, 2022 · 0 comments
Open
2 of 8 tasks

Technical Debt #4300

CarlosLopezDeLara opened this issue Aug 11, 2022 · 0 comments
Assignees

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Aug 11, 2022

WHAT

Resolve top tech debt items

PI 3.5

Spill over to PI 5

Dependencies

  • Keep an eye on optparse-applicative library
  • Decision on d parameter. It is likely not possible. Figure out if we can enable OBFT nodes through other means/modes.

Risks

optparse-applicative / Move from ansi-wl-pprint to prettyprinter) (Risk if our changes are not merged)

  • For us, the prettyprinter library has more intuitive and predictable control over text output and we already use it in other projects. Modifying optparse-applicative to use this library will mean we can use a single library for pretty printing everywhere and not have to deal with two different incompatible libraries that do the same thing. We will not be able to fix the fork of optparse-applicative problem.
  • Relying on a fork long term is untenable because optparse-applicative may release new versions. If that happens we would have to patch our fork to keep up with those. We will end up having to maintain our own fork which will itself cost us effort in the future. We don't want to get into a situation where our code bases uses two incompatible versions of this library and have to stop work to fix builds

d parameter (Risk of full removal)

  • d parameter has been removed from babbage onwards --> it can still be cleaned up (A cosmetic not a functional change)

This conflicts with a request from commercial:

  • Private instances might want to leverage Babbage features while running on OBFT mode --> Maintaining a fork to bring d parameter back is a costly option.**

genesis command (Risk to be mitigated)

  • Condensation might break cardano-testnet and QA tests. Evaluate if it's worth the pain.

Decision: ability to keep creating byron addresses (Risk to be mitigated)

  • Many exchanges still rely on their ability to create byron addresses, we need clearance from exchanges first.
@CarlosLopezDeLara CarlosLopezDeLara moved this from 🌱 Backlog to 🌻 In Progress in Cardano Node Product Backlog Sep 23, 2022
@vfrsilva vfrsilva changed the title 🧘Serenity | Technical debt 💳 Technical Debt Sep 29, 2022
@CarlosLopezDeLara CarlosLopezDeLara changed the title 💳 Technical Debt Technical Debt Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants