Skip to content

Commit 117db8b

Browse files
committed
dmq: sigTTL - use POSIXTime rather than SigTTL
1 parent eedb23a commit 117db8b

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

decentralized-message-queue/src/DMQ/Diffusion/NodeKernel.hs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import Ouroboros.Network.TxSubmission.Inbound.V2.Registry
3333
import Ouroboros.Network.TxSubmission.Mempool.Simple (Mempool (..))
3434
import Ouroboros.Network.TxSubmission.Mempool.Simple qualified as Mempool
3535

36-
import DMQ.Protocol.SigSubmission.Type (Sig (..), SigId, SigTTL (..))
36+
import DMQ.Protocol.SigSubmission.Type (Sig (..), SigId)
3737

3838

3939
data NodeKernel ntnAddr m =
@@ -121,9 +121,9 @@ mempoolWorker (Mempool v) = loop
121121
(sigs :: Seq.Seq Sig) <- readTVar v
122122
let sigs' :: Seq.Seq Sig
123123
(resumeTime, sigs') =
124-
foldr (\a (rt, as) -> if getSigTTL (sigTTL a) <= now
124+
foldr (\a (rt, as) -> if sigTTL a <= now
125125
then (rt, as)
126-
else (rt `min` getSigTTL (sigTTL a), a Seq.<| as))
126+
else (rt `min` sigTTL a, a Seq.<| as))
127127
(now, Seq.empty)
128128
sigs
129129
writeTVar v sigs'

decentralized-message-queue/src/DMQ/Protocol/SigSubmission/Codec.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ codecSigSubmission =
9999
= CBOR.encodeListLen 5
100100
<> encodeSigId sigId
101101
<> CBOR.encodeBytes (getSigBody sigBody)
102-
<> CBOR.encodeWord32 (floor $ getSigTTL sigTTL)
102+
<> CBOR.encodeWord32 (floor sigTTL)
103103
<> CBOR.encodeBytes (getSigKesSignature sigKesSignature)
104104
<> CBOR.encodeBytes (getSigOpCertificate sigOpCertificate)
105105

@@ -109,7 +109,7 @@ codecSigSubmission =
109109
when (a /= 5) $ fail (printf "codecSigSubmission: unexpected number of parameters %d" a)
110110
sigId <- decodeSigId
111111
sigBody <- SigBody <$> CBOR.decodeBytes
112-
sigTTL <- SigTTL . realToFrac <$> CBOR.decodeWord32
112+
sigTTL <- realToFrac <$> CBOR.decodeWord32
113113
sigKesSignature <- SigKesSignature <$> CBOR.decodeBytes
114114
sigOpCertificate <- SigOpCertificate <$> CBOR.decodeBytes
115115
return Sig {

decentralized-message-queue/src/DMQ/Protocol/SigSubmission/Type.hs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ data SigPayload = SigPayload {
7373
pattern Sig
7474
:: SigId
7575
-> SigBody
76-
-> SigTTL
76+
-> POSIXTime
7777
-> SigOpCertificate
7878
-> SigKesSignature
7979
-> Sig
@@ -90,15 +90,15 @@ pattern
9090
SigPayload {
9191
sigPayloadId = sigId,
9292
sigPayloadBody = sigBody,
93-
sigPayloadTTL = sigTTL,
93+
sigPayloadTTL = SigTTL sigTTL,
9494
sigPayloadOpCertificate = sigOpCertificate
9595
},
9696
sigRawKesSignature = sigKesSignature
9797
}
9898
where
9999
Sig sigPayloadId
100100
sigPayloadBody
101-
sigPayloadTTL
101+
sigTTL
102102
sigPayloadOpCertificate
103103
sigRawKesSignature
104104
=
@@ -107,7 +107,7 @@ pattern
107107
SigPayload {
108108
sigPayloadId,
109109
sigPayloadBody,
110-
sigPayloadTTL,
110+
sigPayloadTTL = SigTTL sigTTL,
111111
sigPayloadOpCertificate
112112
},
113113
sigRawKesSignature

decentralized-message-queue/test/Test/DMQ/Protocol/SigSubmission.hs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ instance Arbitrary SigOpCertificate where
7373
instance Arbitrary Sig where
7474
arbitrary = Sig <$> arbitrary
7575
<*> arbitrary
76+
<*> (getSigTTL <$> arbitrary)
7677
<*> arbitrary
7778
<*> arbitrary
7879
shrink sig@Sig { sigId, sigBody, sigTTL, sigOpCertificate, sigKesSignature } =
@@ -85,7 +86,7 @@ instance Arbitrary Sig where
8586
]
8687
++
8788
[ sig { sigTTL = sigTTL' }
88-
| sigTTL' <- shrink sigTTL
89+
| SigTTL sigTTL' <- shrink (SigTTL sigTTL)
8990
]
9091
++
9192
[ sig { sigOpCertificate = sigOpCertificate' }

0 commit comments

Comments
 (0)