Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clients should respond to ControlMessage #2528

Open
4 of 5 tasks
coot opened this issue Aug 20, 2020 · 1 comment · Fixed by #2531
Open
4 of 5 tasks

Clients should respond to ControlMessage #2528

coot opened this issue Aug 20, 2020 · 1 comment · Fixed by #2531

Comments

@coot
Copy link
Contributor

coot commented Aug 20, 2020 •
edited
Loading

ControlMessage is available here. Consensus clients will only see Continue or Terminate constructors of ControlMessage (the Quiesce constructor is used only for established protocols, e.g. keep-alive.)

Please open a PR against coot/connection-manager.

  • chain-sync
  • block-fetch
  • tx-submission
  • keep-alive
  • tip-sample
@coot coot added the consensus issues related to ouroboros-consensus label Aug 20, 2020
@coot coot mentioned this issue Aug 20, 2020
Merged
@mrBliss mrBliss mentioned this issue Aug 21, 2020
Merged
@mrBliss mrBliss linked a pull request Aug 21, 2020 that will close this issue
ChainSyncClient: respond to ControlMessageSTM #2531
Merged
@mrBliss mrBliss removed their assignment Aug 28, 2020
@mrBliss mrBliss removed the consensus issues related to ouroboros-consensus label Aug 28, 2020
@mrBliss mrBliss changed the title Consenus clients should respond to ControlMessage Clients should respond to ControlMessage Aug 28, 2020
@mrBliss
Copy link
Contributor

mrBliss commented Aug 28, 2020

Only the ChainSync client is defined in the consensus layer. All others are in the network layer. So I'm removing "consensus" and myself from this issue.

@coot coot removed the networking label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Ouroboros Network
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ChainSyncClient: respond to ControlMessageSTM IntersectMBO/ouroboros-network
2 participants
@mrBliss @coot