Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demoting non-hot peer assertion #3586

Closed
karknu opened this issue Jan 25, 2022 · 2 comments · Fixed by #3588
Closed

Demoting non-hot peer assertion #3586

karknu opened this issue Jan 25, 2022 · 2 comments · Fixed by #3588
Assignees
@karknu
Labels
outbound-governor Issues / PRs related to outbound-governor

Comments

@karknu
Copy link
Contributor

karknu commented Jan 25, 2022

cardano-node: Assertion failed
CallStack (from HasCallStack):
assert, called at src/Ouroboros/Network/PeerSelection/Governor/Types.hs:405:5 in ouroboros-network-0.1.0.0-50a0e8b5b3073b11a5c3eb6b69bfa5d0e19a94e02b399c4c2c0793212741011c:Ouroboros.Network.PeerSelection.Governor.Types

Assert line:
assert (Set.isSubsetOf inProgressDemoteHot hotPeersSet)
@karknu karknu self-assigned this Jan 25, 2022
@karknu karknu moved this to In Progress in Ouroboros Network Jan 25, 2022
@coot coot added the outbound-governor Issues / PRs related to outbound-governor label Jan 26, 2022
@karknu
Copy link
Contributor Author

karknu commented Jan 26, 2022

Fixed in #3588

@coot coot linked a pull request Jan 31, 2022 that will close this issue
Ignore monitoring of cold hot cons beeing demoted #3588
Merged
@coot
Copy link
Contributor

coot commented Jan 31, 2022

btw, github only links pull requests if the issues are mentioned in the issue description not a comment. Otherwise one needs to do that manually; but once that's done the project will close the issue once the PR is merged.

@coot coot closed this as completed Jan 31, 2022
Repository owner moved this from In Progress to Done in Ouroboros Network Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karknu karknu

Labels
outbound-governor Issues / PRs related to outbound-governor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore monitoring of cold hot cons beeing demoted IntersectMBO/ouroboros-network
2 participants
@coot @karknu