Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes should not request TXs during bulk sync #4955

Open
karknu opened this issue Sep 10, 2024 · 0 comments
Open

Nodes should not request TXs during bulk sync #4955

karknu opened this issue Sep 10, 2024 · 0 comments
Labels
high-priority high priority issues / PRs optimisation Performance optimisation tx-submission Issues related to tx-submission protocol

Comments

@karknu
Copy link
Contributor

karknu commented Sep 10, 2024

When a node is so far behind that it operates in bulksync mode it should not request TXs from any peers. It is very unlikely that it would be able to apply any of them to its mempool. It is already CPU bound and sprinkling in attempts to add TXs to the mempool will only slow things down further.

TX-submission should be modified so that it doesn't request TX when in bulk sync mode.
@karknu karknu added tx-submission Issues related to tx-submission protocol optimisation Performance optimisation labels Sep 10, 2024
@coot coot added the high-priority high priority issues / PRs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high-priority high priority issues / PRs optimisation Performance optimisation tx-submission Issues related to tx-submission protocol
Projects
Ouroboros Network
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coot @karknu