Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into upgrading to flat ^>= 0.6 on master and check that the script dump test continues to pass #5309

Closed
erikd opened this issue May 9, 2023 · 4 comments
Closed

Look into upgrading to flat ^>= 0.6 on master and check that the script dump test continues to pass #5309

erikd opened this issue May 9, 2023 · 4 comments
Assignees
@bezirg
Labels
Internal status: triaged

Comments

@erikd
Copy link
Contributor

erikd commented May 9, 2023 •
edited
Loading

@bezirg could you look into upgrading to flat >= 0.6 on master and check that the script dump test continues to pass?

Originally posted by @michaelpj in #5286 (comment)
@github-actions github-actions bot added the status: needs triage GH issues that requires triage label May 9, 2023
@bezirg
Copy link
Contributor

bezirg commented May 9, 2023

Yes, I am taking a look now.

@erikd
Copy link
Contributor Author

erikd commented May 9, 2023

@bezirg I think the constraint needs to be flat ^>= 0.6.

@bezirg
Copy link
Contributor

bezirg commented May 9, 2023

@erikd It will take a bit more time (couple of days) since the old infra is not there and we have to rebuild the script dumps from the start.

@effectfully effectfully added status: triaged Internal and removed status: needs triage GH issues that requires triage labels May 9, 2023
@erikd erikd mentioned this issue May 18, 2023
Merged
@erikd erikd changed the title Look into upgrading to flat >= 0.6 on master and check that the script dump test continues to pass Look into upgrading to flat ^>= 0.6 on master and check that the script dump test continues to pass May 18, 2023
@erikd
Copy link
Contributor Author

erikd commented May 19, 2023

@bezirg I understand this is complete and everything checked out ok?

@bezirg bezirg closed this as completed May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bezirg bezirg

Labels
Internal status: triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erikd @bezirg @effectfully