Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for file assets customization instead of hardcoded icons #21

Open
fawni opened this issue May 18, 2024 · 1 comment
Open

Allow for file assets customization instead of hardcoded icons #21

fawni opened this issue May 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@fawni
Copy link

fawni commented May 18, 2024

Is your feature request related to a problem? Please describe.
utils.get_asset_url is hardcoded to use icons from this repository. this makes the file_assets config option practically useless; as you cannot use any icons outside of this repository.

Describe the solution you'd like
Ideally, these icons should be uploaded to the (default) discord application instead of fetched from the github repository. this will also allow customization through custom discord applications as well as using external urls. this is the default behavior of presence.nvim.

@fawni fawni added the enhancement New feature or request label May 18, 2024
@IogaMaster
Copy link
Owner

IogaMaster commented May 18, 2024

This is intended, as managing assets on discord sucks. When using urls updates are repo only (ie I don't need to do anything other than merging a pr).

To update the icons just override the file_assets. When it's fixed.
I will get to that soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants