Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Add death_entity event #13

Open
elhertz opened this issue Sep 15, 2021 · 3 comments
Open

[REQUEST] Add death_entity event #13

elhertz opened this issue Sep 15, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@elhertz
Copy link

elhertz commented Sep 15, 2021

An event for players killed by an entity.
Also ${killerEntity} for the entity name.

@elhertz elhertz added the enhancement New feature or request label Sep 15, 2021
@PortableGames
Copy link

it's probably a good idea maybe even for killentity... you can use different sentences and commands for different types of mob.. but it will be difficult to translate into other languages than english.. but it's a good idea I'm in favour of it

@PortableGames
Copy link

for translations into other languages you would need to make a config where you name individual ${killerEntity} ${killedEntity} and then the mod will print the names from the translation config

@elhertz
Copy link
Author

elhertz commented Sep 15, 2021

What about using the client's lang keys instead of translating every entity name? I've seen other mods doing that

edit: this mod for example https://github.com/Patbox/UniversalGraves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants