Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix score dataclip(s) by late April [5,3,1.67] #2360

Closed
stenington opened this issue Jan 24, 2020 · 12 comments
Closed

Fix score dataclip(s) by late April [5,3,1.67] #2360

stenington opened this issue Jan 24, 2020 · 12 comments
Assignees

Comments

@stenington
Copy link
Contributor

stenington commented Jan 24, 2020

Dataclips referencing old score columns will be broken, e.g.

Are there others?

@stenington
Copy link
Contributor Author

From #2264

@rsgonzal
Copy link
Collaborator

Looking at Amy's data archive here: https://docs.google.com/document/d/1AJJH9Hq7s7HRQ726w3MkK0fgYbM2_1RxdQx1kpwqIHM/edit

I think the dataclip above is the only one used and the rest is pulled from the site. Is this correct, @amyiridescent and should I check with anyone else?

@amyiridescent
Copy link

Yes I believe that is true but I can't get the data clip to run right now. I am getting an error.
image

@rsgonzal
Copy link
Collaborator

rsgonzal commented Jan 27, 2020

Thanks, @amyiridescent ! This ticket is to fix that ^^ :)

@hellafitz hellafitz changed the title Fix score dataclip(s) Fix score dataclip(s) [3,3,1] (by late April) Feb 26, 2020
@stenington
Copy link
Contributor Author

This fits roughly under the theme of #2392 in that I believe if it isn't fixed, monitoring scores will become more of a developer problem.

@rsgonzal rsgonzal added it-19 and removed it-17 labels Mar 11, 2020
@hellafitz hellafitz changed the title Fix score dataclip(s) [3,3,1] (by late April) Fix score dataclip(s) [5,3,1.67] (by late April) Mar 24, 2020
@rsgonzal rsgonzal added it-20 and removed it-18 labels Mar 25, 2020
@hellafitz hellafitz changed the title Fix score dataclip(s) [5,3,1.67] (by late April) Fix score dataclip(s) by late April [5,3,1.67] Mar 25, 2020
@hellafitz hellafitz removed the it-20 label Mar 25, 2020
@shaun-technovation shaun-technovation self-assigned this Mar 26, 2020
@shaun-technovation
Copy link
Contributor

The new/updated dataclip is here: https://data.heroku.com/dataclips/daqfepdhedhrlripdngbdskqiihj

A couple of notes:

  • I created a new dataclip from the existing one
  • There doesn't seem to be an easy way to copy an existing dataclip 🤕 😳
  • There isn't a PR
  • I ran the dataclip against QA/staging data and was able to get some results
  • The year in the dataclip is still set to 2019
  • This might be nice to have in the app for admins to view

@stenington
Copy link
Contributor Author

Dataclips used to be versioned so each time you edited it a new version was created, but it looks like the new dataclips don't do that which is a bummer.

I agree this would be nicer in the app, but for context I think the reason it's in a dataclip is because Amy likes to have data in spreadsheets to work with, and the platform's CSV export is much flakier than dataclips are. So until we can address that flakiness, dataclips are the more reliable solution.

@amyiridescent
Copy link

Yeah sorry Shaun. I like to manipulate the date on a spreadsheet. It helps that I already know how to write functions on google spreadsheet. :) And I try not to do the CSV exports too often since it tends to get stuck or crashes. Sorry for being old school.

@shaun-technovation
Copy link
Contributor

Yeah sorry Shaun. I like to manipulate the date on a spreadsheet. It helps that I already know how to write functions on google spreadsheet. :) And I try not to do the CSV exports too often since it tends to get stuck or crashes. Sorry for being old school.

Ah, no worries! 😃 Anywho, when you get a moment, can you check out the new dataclip, and see if it's working as expected?

https://data.heroku.com/dataclips/daqfepdhedhrlripdngbdskqiihj

Right now it's pointing at staging for the 2019 season, if it's working as expected I'll updated it to 2020, and point it production, and it should be good to go for the 2020 season. 😃

@amyiridescent
Copy link

Data clip looks good. :)

Thanks Shaun for helping me the the dataclip share settings. :)

@shaun-technovation
Copy link
Contributor

Thanks @amyiridescent! 👍 🙌 🎉

I updated the year in the dataclip to 2020 and also pointed it to production.

@rsgonzal rsgonzal added 7 - Ready to Deploy and removed 6 - Test Keep <= 8 labels Mar 31, 2020
@shaun-technovation
Copy link
Contributor

I'll move this one to Done, since there's nothing to deploy for this. 👍 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants