Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to onboard_missed_students! task [3,3,1] #2671

Open
shaun-technovation opened this issue Sep 17, 2020 · 6 comments
Open

Add logging to onboard_missed_students! task [3,3,1] #2671

shaun-technovation opened this issue Sep 17, 2020 · 6 comments

Comments

@shaun-technovation
Copy link
Contributor

shaun-technovation commented Sep 17, 2020

From #2372, we haven't been able to reproduce this bug.

We have a task, onboard_missed_students! that runs that will fix this issue. We should add some kind of logging, or email us, or something to this task to give us some insights into how often this is happening, and to hopefully let us investigate further on how to reproduce this bug.

@stenington
Copy link
Contributor

My suggestion would be configuring a Papertrail alert on the "Student# should be onboarded" message that the task currently logs.

@hellafitz hellafitz added ready tech upkeep and removed 🗣 Discuss ✋ Needs discussion labels Sep 23, 2020
@hellafitz
Copy link
Collaborator

deliverable: set up a slack alert to dev-robots when this happens

@hellafitz hellafitz changed the title Add logging to onboard_missed_students! task Add logging to onboard_missed_students! task [3,3,1] Sep 23, 2020
@stenington
Copy link
Contributor

An alert is now configured to log to #dev-robots as Papertrail once a day if it sees messages in the logs with "should be onboarded". It's hard to test this until we start seeing this happen again in production.

@rsgonzal
Copy link
Collaborator

rsgonzal commented Oct 2, 2020

This may or may not be related.

I was using a returning user (roxana+11@technovation.org) and was not able to create a team. I was able to put her on a team and it looked like she needed her consent for signed. So I searched through my email and signed it. Then I saw the same thing as the screenshot in #2372. I somehow got to the page to resend the consent form and it said my parent's email was another student's, but my consent form was signed already. I decided to change it anyways and sign again with another email and after that i was able to create a team. I also am no longer pending. I THEN searched for the email I had been using, and there is no student in the system with that email.

Screen Shot 2020-10-01 at 8 22 32 PM

@rsgonzal
Copy link
Collaborator

rsgonzal commented Oct 7, 2020

Ophelie's student Sara Croche was a new student who was pending for no reason.

Consent form was signed, but i went in to change the email anyways. This time it didn't give me an error for the email address. I sent the form again anyways, to the same parent email on the account. This fixed the error. I did NOT need to sign the new consent form

Same thing for her student stella noir

@hellafitz
Copy link
Collaborator

add to staging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants