Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check locations that have previously stored incorrectly #4579

Open
dboyer opened this issue Mar 15, 2024 · 5 comments
Open

Check locations that have previously stored incorrectly #4579

dboyer opened this issue Mar 15, 2024 · 5 comments
Assignees

Comments

@dboyer
Copy link

dboyer commented Mar 15, 2024

Building on #4563 it may be helpful to check how the city state gem would deal with locations where we've previously had issues with correctly identifying the city or region.

Specific previous issues include:

  • Some Spain provinces get listed in multiple ways. I will bold the version that most are registered under and then list other variations underneath that.
    Madrid, Comunidad de
    Community of Madrid
    Comunidad de Madrid
    Valenciana, Comunidad / Valenciana, Comunitat
    Comunidad Valenciana
    Valencian Community
    Murcia, Región de
    Region of Murcia
    Región de Murcia

  • Walenjikha (City), Samegrelo-Zemo Svaneti (Region) in the country of Georgia gets listed under United States instead

  • Occasionally, some City listings in Nigeria get detached from the States. It's not a large number, but it seems like some people are able to just push through with different combinations. Examples: There are several listings in Imo (State) that have incorrect cities. For example, someone put Lagos (City), Imo, someone put Nigeria (as a City), Imo. A couple accounts with just Lagos as the city and no state.

  • Mexico states are mostly abbreviated though occasionally some get the full spelling. There's a lot of "Jal." but a few slip by with the full spelling "Jalisco" Similarly, "Ver." vs "Veracruz"

  • Palestine (Ohio or the state)

  • Jammu and Kashmir

  • Mexico City (listed various ways in the database)

@dboyer dboyer changed the title Add field to store and ed Check locations that have previously stored incorrectly Mar 18, 2024
@viviancan viviancan self-assigned this Mar 18, 2024
@viviancan
Copy link
Contributor

Country State City
CS.states("ES") -->:MD => "Madrid" CS.cities (:MD) "Madrid"
CS.states("ES") -->:VC=>"Valencia" CS.cities (:VC) "Valencia"
CS.states("ES") -->:MC=>"Murcia", CS.cities (:MC) "Murcia"
CS.states("GE") --> :SZ=>"Samegrelo and Zemo Svaneti", CS.cities (:SZ) ["Zugdidi"]
CS.states("NG") --> :IM=>"Imo State" CS.cities (:IM) ["Owerri"]
CS.states("MX") --> :DIF=>"Mexico City CS.cities (:DIF) ["Mexico City"]
CS.states("PS") --> :DIF=>":"Gaza Strip"=>"Gaza Strip", -------- -------
CS.states("IN") -->:JK=>"Kashmir" CS.cities (:JK) ["Jammu"]

@viviancan
Copy link
Contributor

viviancan commented Mar 18, 2024

States listed in Nigeria

irb(main):030:0> CS.states("NG")
=> 
{:AB=>"Abia State",                                                                            
 :AD=>"Adamawa",                                                                               
 :AK=>"Akwa Ibom State",                                                                       
 :BE=>"Benue State",                                                                           
 :CR=>"Cross River State",
 :DE=>"Delta",
 :EB=>"Ebonyi State",
 :ED=>"Edo",
 :EK=>"Ekiti State",
 :EN=>"Enugu State",
 :FC=>"Federal Capital Territory",
 :IM=>"Imo State",
 :KD=>"Kaduna State",
 :KE=>"Kebbi State",
 :KN=>"Kano State",
 :KO=>"Kogi State",
 :KT=>"Katsina State",
 :KW=>"Kwara State",
 :LA=>"Lagos",
 :NI=>"Niger State",
 :OG=>"Ogun State",
 :ON=>"Ondo State",
 :OS=>"Osun State",
 :OY=>"Oyo State",
 :PL=>"Plateau State",
 :RI=>"Rivers State",
 :SO=>"Sokoto State",
 :TA=>"Taraba State",
 :YO=>"Yobe State",
 :ZA=>"Zamfara State"}

States listed in MX

:AGU=>"Aguascalientes",                                                                               
 :BCN=>"Estado de Baja California",                                                                    
 :BCS=>"Baja California Sur",                                                                          
 :CAM=>"Campeche",                                                                                     
 :CHH=>"Chihuahua",                                  
 :CHP=>"Chiapas",                                    
 :COA=>"Coahuila",                                   
 :COL=>"Colima",                                     
 :DIF=>"Mexico City",                                
 :DUR=>"Durango",                                    
 :GRO=>"Guerrero",
 :GUA=>"Guanajuato",
 :HID=>"Hidalgo",
 :JAL=>"Jalisco",
 :MEX=>"Estado de Mexico",
 :MIC=>"Michoacán",
 :MOR=>"Morelos",
 :NAY=>"Nayarit",
 :NLE=>"Nuevo León",
 :OAX=>"Oaxaca",
 :PUE=>"Puebla",
 :QUE=>"Querétaro",
 :ROO=>"Quintana Roo",
 :SIN=>"Sinaloa",
 :SLP=>"San Luis Potosí",
 :SON=>"Sonora",
 :TAB=>"Tabasco",
 :TAM=>"Tamaulipas",
 :TLA=>"Tlaxcala",
 :VER=>"Veracruz",
 :YUC=>"Yucatán",
 :ZAC=>"Zacatecas"}

States listed in INDIA

rb(main):045:0> CS.states(:IN)
=>
{:AN=>“Union Territory of Andaman and Nicobar Islands”,
 :AP=>“Andhra Pradesh”,
 :AR=>“Arunachal Pradesh”,
 :AS=>“Assam”,
 :BR=>“Bihar”,
 :CH=>“Chandigarh”,
 :CT=>“State of Chhattisgarh”,
 :DD=>“Daman and Diu”,
 :DL=>“National Capital Territory of Delhi”,
 :DN=>“Dadra and Nagar Haveli”,
 :GA=>“Goa”,
 :GJ=>“Gujarat”,
 :HP=>“State of Himachal Pradesh”,
 :HR=>“Haryana”,
 :JH=>“State of Jharkhand”,
 :JK=>“Kashmir”,
 :KA=>“Karnataka”,
 :KL=>“Kerala”,
 :LD=>“Laccadives”,
 :MH=>“Maharashtra”,
 :ML=>“Meghalaya”,
 :MN=>“Manipur”,
 :MP=>“Madhya Pradesh”,
 :MZ=>“Mizoram”,
 :NL=>“Nagaland”,
 :OR=>“Odisha”,
 :PB=>“State of Punjab”,
 :PY=>“Union Territory of Puducherry”,
 :RJ=>“Rajasthan”,
 :SK=>“Sikkim”,
 :TG=>“Telangana”,
 :TN=>“Tamil Nadu”,
 :TR=>“Tripura”,
 :UL=>“Uttarakhand”,
 :UP=>“Uttar Pradesh”,
 :WB=>“West Bengal”}

States listed in PS

irb(main):051:0> CS.states("PS")
=> {:"Gaza Strip"=>"Gaza Strip", :"West Bank"=>"West Bank"}

@viviancan
Copy link
Contributor

@dboyer I had trouble finding Walenjikha (City), Samegrelo-Zemo Svaneti (Region) within the Samegrelo-Zemo Svaneti Region. I also think locations in Nigeria are missing (which aligns with this issue someone posted in the repo)

@viviancan
Copy link
Contributor

I created #4587 to review location data from 2023 & 2024 to determine location coverage

@dboyer
Copy link
Author

dboyer commented Mar 22, 2024

One additional example:

We also have had issues with regions not showing at all when filtering to that region - ex: Hyderabad in Telangana, India. If you look at all of India on production, you can see we have at least 50+ accounts (showing as TS or Telangana) but it does not show when using the filters (even the few accounts that show as Telangana for the state).

Screen Shot 2024-03-22 at 1 02 47 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants