Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Memory Leak. Excessive memory usage after changing settings one too many times. #2559

Open
djmrFunnyMan opened this issue Dec 7, 2024 · 2 comments

Comments

@djmrFunnyMan
Copy link

djmrFunnyMan commented Dec 7, 2024

What happened?

I was messing with shader settings to look into a shader issue. I noticed that after messing with the settings for a while memory usage will constantly climb higher until it hits the allocation limit and constatnly triggers garbage collector resulting in heavy lag and the game being unplayable.
https://github.com/user-attachments/assets/2118e831-1296-4ce5-b80b-8e011b786fd0

Off the top of my head I think it might be related to Iris caching past shader settings so they compile faster if you select them again. Are those stored in the RAM? I feel like only the second most recent settings should be kept in RAM and the rest temporarily saved on the hard drive.

Screenshots

Freshly loaded into the world:
Image
After messing with settings for a while:
Image

Log output

latest.log
crash-2024-12-08_16.41.18-client.txt

Minecraft Version

1.21.4

Iris Version

iris-fabric-1.8.3+mc1.21.4.jar

Operating System

Windows 11

What is your GPU?

GTX 1060 6GB

Additional context

No response

@djmrFunnyMan
Copy link
Author

djmrFunnyMan commented Dec 8, 2024

Here's a spark profile

Before: https://spark.lucko.me/mUrVkkg3YO

After: https://spark.lucko.me/WocejZ3TdH

@djmrFunnyMan
Copy link
Author

Eventually you'll be simply unable to load the shader at all due to java.util.concurrent.ExecutionException: java.lang.OutOfMemoryError: Java heap space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant