Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sodium for 1.17 disables sky rendering when underwater and when blind, breaking some shader packs #645

Closed
coderbot16 opened this issue Jul 28, 2021 · 7 comments

Comments

@coderbot16
Copy link
Member

This was caused by CaffeineMC/sodium#710

I think disabling the "sunset" part when underwater should fix most of the weird visual issues without breaking packs.

@IMS212
Copy link
Member

IMS212 commented Jul 28, 2021

Would disabling the PR if a shaderpack is loaded be an adequate fix?

@sylv256
Copy link

sylv256 commented Jul 28, 2021

I am able to reproduce this bug with my test shaderpack. https://github.com/CursedMC/sodium-iris-fog-test

Note: The blindness status effect is currently broken in the shaderpack. As far as I'm aware, it isn't an iris bug.

@coderbot16
Copy link
Member Author

That would work for now, and I can investigate disabling the sunset effect while underwater / blind later.

@IMS212
Copy link
Member

IMS212 commented Jul 28, 2021

Sounds good, I’ll change it.

@sylv256
Copy link

sylv256 commented Jul 28, 2021

That would work for now, and I can investigate disabling the sunset effect while underwater / blind later.

You may also want to disable clouds while underwater too.

@sylv256
Copy link

sylv256 commented Jul 28, 2021

I've tested the test shader against the latest sodium + iris builds and it appears to be fixed.

@coderbot16
Copy link
Member Author

Fixed in IrisShaders/sodium-fabric@f42a255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants