Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apple silicon (arm64) support? #70

Closed
wobo-lance-tipton opened this issue Jan 14, 2022 · 2 comments
Closed

Add apple silicon (arm64) support? #70

wobo-lance-tipton opened this issue Jan 14, 2022 · 2 comments
Assignees

Comments

@wobo-lance-tipton
Copy link

wobo-lance-tipton commented Jan 14, 2022

Looks like arm64 is not a supported platform, would it be possible to add support for Apple silicon?
The readme says to open an issue to potentially get support added.
Would this be possible?

Here's an image for context:
Screen Shot 2022-01-13 at 5 16 35 PM

Please let me know if there's some more you need from me.
Thanks

@wobo-lance-tipton
Copy link
Author

Quick update, I was able to do a local build of recrypt-node-binding on my Apple Silicon machine.
Basically, I had to

  • Install rust on apple silicon using the latest beta channel
  • Add arm64 to the list of supported cpu's in the package.json
       "cpu": [
         "x64",
         "arm64"
       ],
  • Then I just ran yarn compile and node publish.js, both of which worked

Output of the node ./publish.js command after running yarn compile

Screen Shot 2022-01-13 at 6 33 00 PM

So the good news is it should work.
I could fork the repos and publish them so they can be installed with a simple yarn install, but it would be nice if it could be part of the original repo.

The other option that might work, is allow setting an ENV like RECRYPT_NODE_PATH=/path/to/compile/binary when installing ironnode

Thanks

@wobo-lance-tipton
Copy link
Author

Closing, in lieu of IronCoreLabs/recrypt-node-binding#79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants