Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Consider switching to prost for protobuf serialization #184

Closed
clintfred opened this issue Sep 29, 2020 · 1 comment
Closed

[SPIKE] Consider switching to prost for protobuf serialization #184

clintfred opened this issue Sep 29, 2020 · 1 comment

Comments

@clintfred
Copy link
Contributor

clintfred commented Sep 29, 2020

We should consider switching to from rust-protobuf to https://github.com/danburkert/prost.

We are accumulating lots of workarounds to things working. There also might be better ways to use rust-protobuf too, but our experience with that project hasn't been very good so looking at an alternative makes some sense.

We didn't use prost originally as the project looked very inactive, but I think some bigger rust projects are now behind it and it's very active now.

EDIT: I also see now that rust-protobuf is adding better support for our use case. See stepancheg/rust-protobuf#525

@BobWall23 BobWall23 changed the title Consider switching to prost for protobuf serialization [SPIKE] Consider switching to prost for protobuf serialization Oct 7, 2020
@giarc3
Copy link
Member

giarc3 commented Jun 16, 2022

prost is possibly abandoned, but rust-protobuf is continuing to be maintained/improved. In addition, new features have allowed us to remove our workarounds. So we will stick with rust-protobuf for now

@giarc3 giarc3 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants