Reworking fcrepo indexer to be file system aware #51
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
============================================
+ Coverage 79.47% 80.36% +0.88%
- Complexity 56 93 +37
============================================
Files 11 17 +6
Lines 229 331 +102
Branches 1 1
============================================
+ Hits 182 266 +84
- Misses 46 64 +18
Partials 1 1
Continue to review full report at Codecov.
|
| @@ -14,26 +14,28 @@ | |||
| ] | |||
| }, | |||
| "object":{ | |||
| "id":"urn:uuid:3d3550ff-1d4c-4484-a406-8f97c1673e5c", | |||
| "id":"urn:uuid:72358916-51e9-4712-b756-4b0404c91b1d", | |||
| "url":[ | |||
| { | |||
| "name":"Canoncial", | |||
There was a problem hiding this comment.
This should be "Canonical" instead of Canocial
There was a problem hiding this comment.
Good catch @DiegoPino. Thanks man. I'll update that shortly.
There was a problem hiding this comment.
LOL, found the source of it: https://github.com/Islandora-CLAW/islandora/blob/8.x-1.x/src/EventGenerator/EventGenerator.php#L114
| "id":"urn:uuid:4f528a92-4be2-4a9d-85e6-c5f4d36b1bce", | ||
| "url":[ | ||
| { | ||
| "name":"Canoncial", |
| "id":"urn:uuid:148dfe8f-9711-4263-97e7-3ef3fb15864f", | ||
| "url":[ | ||
| { | ||
| "name":"Canoncial", |
There was a problem hiding this comment.
Same as before, "Canonical", probably replicated from copy/paste
| .removeHeaders("*", "Authorization") | ||
| .setHeader(Exchange.HTTP_METHOD, constant("POST")) | ||
| .setHeader("Content-Location", simple("${exchangeProperty.jsonUrl}")) | ||
| .transform(simple("${null}")) |
There was a problem hiding this comment.
Could this just be .setBody(simple("${null}")) instead of a transform?
There was a problem hiding this comment.
I'm not 100% sure what the difference is, but "setBody" seems clearer to me. I'll have to try it out to know for sure.
There was a problem hiding this comment.
I think transform() is part of the message translator EIP, so if you are just wanting to make the body of the message empty I think .setBody() would be more efficient.
But I don't know for sure
There was a problem hiding this comment.
Whelp, I did it and tested it and nothing seems to have changed, so I'm pushing it up. It just reads better IMO.
|
@DiegoPino can I merge this, I think your requests have been addressed. |
|
@whikloj i did not get to test all the code, but my concerns are addressed, feel free to merge, you know the internals way better |
GitHub Issue: Part of Islandora/documentation#769
What does this Pull Request do?
Updates islandora-indexing-fcrepo to handle the new message format, and deposits derivatives in the filesystem selected through the Drupal UI. Don't mind all the POJO boilerplate.
How should this be tested?
Test as part of Islandora/documentation#92
Additional Notes:
Needs tests, just putting this out there before wrapping it all up.
Interested parties
@Islandora-CLAW/committers