Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make islandora_search theme independent #1100

Closed
Natkeeran opened this issue Apr 26, 2019 · 3 comments
Closed

make islandora_search theme independent #1100

Natkeeran opened this issue Apr 26, 2019 · 3 comments

Comments

@Natkeeran
Copy link
Contributor

This block is dependent on carspace theme. However, when we try to enable drupal modules, the theme is not installed.

The block should not be dependent on theme. The block should be made available, and the user would have to place it in an existing region.

@Natkeeran Natkeeran changed the title make islandora_search theme indendent make islandora_search theme independent Apr 26, 2019
@dannylamb
Copy link
Contributor

I'm reading this as "Remove the block yml and add install instructions / point to documentation".

@Natkeeran
Copy link
Contributor Author

Natkeeran commented Apr 26, 2019

@dannylamb

Hmm, ok. No, sample block is good.

Seems like there is no way to define a block without tying to a theme, is that correct?

Simply adding islandora_search to here https://github.com/Islandora-Devops/claw-playbook/blob/master/inventory/vagrant/group_vars/webserver/drupal.yml#L48 does not work, because it needs carspace theme.

We would have to enable it after here: https://github.com/Islandora-Devops/claw-playbook/blob/master/roles/internal/webserver-app/tasks/drupal.yml#L47, which is not clean, but should work. Or we can leave it un installed!

@Natkeeran
Copy link
Contributor Author

This issue has been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants