-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Islandora tokens? #1171
Comments
With the caveat that I haven't done much of anything with tokens: It seems logical to me to have token support added to controlled access terms since we define the LinkedAgent field here. However, the PR as it stands has some hard-coded expectations such as the field's machine name (field_linked_agent, defined in islandora_defaults) using the MARC relators ontology (used in controlled_access_terms_defaults, but others may use schema.org relationships instead). I would suggest either 1) moving the code to islandora_defaults, since it does rely on a field from there, OR 2) a refactored PR to make it more generalized (perhaps using field types instead of a field's machine name?). |
Adding tokens for the results of our various EVAs would be super useful. For example, if we want to do schema.org metatags, then we need to be able to get at the thumbnail using a token for the node. Something like |
@dannylamb We're using something like this for dcterms & og & twitter metatags.
I can share more code in a week. |
@dannylamb I've made a start at https://github.com/kayakr/islandora_tokens |
@kayakr Can haz PR? That looks like a great start. I'd go ahead and stick it straight into |
Ok - now there are two separate pull requests that should put all of the tokens under either |
@dannylamb Since Islandora/islandora#836 has already been merged and closed, a new PR has been made for the islandora project for the commits that put the |
These are useful in pathauto paths, for default values in embedded entities, in metatag fields, etc.
I've suggested a linked-agent token e.g.
[node:linked-agent:cre]
at Islandora/controlled_access_terms#30 but perhaps there needs to be some wider discussion about where such tokens should live; in their own islandora_tokens module, or in some specific modules such as controlled_access_terms or even a linked_agent module?The text was updated successfully, but these errors were encountered: