Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR Template to Islandora-Devops Ansible Roles #1177

Closed
jonathangreen opened this issue Jun 21, 2019 · 3 comments · Fixed by islandora-deprecated/ansible-role-tomcat8#9
Closed

Add PR Template to Islandora-Devops Ansible Roles #1177

jonathangreen opened this issue Jun 21, 2019 · 3 comments · Fixed by islandora-deprecated/ansible-role-tomcat8#9

Comments

@jonathangreen
Copy link
Contributor

@dbernstein noticed when submitting islandora-deprecated/ansible-role-tomcat8#8 that the Ansible roles don't have our PR template. Might be good to ad them. Figured I'd make a ticket so we don't forget about it.
@jonathangreen
Copy link
Contributor Author

PR template file is here:
https://github.com/Islandora-CLAW/islandora/blob/8.x-1.x/.github/PULL_REQUEST_TEMPLATE.md

dbernstein added a commit to dbernstein/ansible-role-tomcat8 that referenced this issue Jun 21, 2019
@dbernstein
Adds PR template.
5a272a3 
Resolves: Islandora/documentation#1177
@dbernstein dbernstein mentioned this issue Jun 21, 2019
Merged
@seth-shaw-unlv
Copy link
Contributor

This must have auto-closed when I merged the referenced PR. Reopening as we should make sure the other roles also have the template.

@dbernstein
Copy link

There are template PRs for all the other roles.

@manez manez mentioned this issue Jun 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds PR template. dbernstein/ansible-role-tomcat8
3 participants
@dbernstein @jonathangreen @seth-shaw-unlv