-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fedora URI pseudofield doesn't work on Taxonomy Terms #1288
Comments
(Going off the top of my head, need to verify this theory.) This is probably due to how we use field_external_uri. Taxonomy terms that use that field would be known by their external URI rather than the Drupal URI which is what we use to query Gemini; thus Gemini is just shrugging. We probably need the bit of code that does the Gemini lookup to check for the presence of external_uri and use that value instead. |
Nope. Scratch that theory; and I should have read your ticket description more carefully. |
I recreated this and from the Gemini logs it looks like an authentication issue:
Not entirely sure why taxonomy terms are different than media/nodes in this situation, TBH. But that's what's happening. |
Not sure how you even got that far @dannylamb. Mine doesn't even get past this line to verify entity type. Changing the line to |
Nope, actually that edit only works for taxonomy terms. Nodes start failing there (which I didn't realize because I hadn't cleared my cache for the node I checked 🤦♂️). I feel like we've hit something like this before.... where was that? Breadcrumbs, maybe? Grumble, grumble, flipping through random stacks of papers, grumble, grumble... |
Did a quick dive and am now thinking that log entry is a red herring. Turns out, its because the taxonomy term display is actually a view. The route parameters are handled slightly differently, and we just need to account for that. For a node/media, the route match returns parameters nested in an array and keyed by their name. For the view, the entity that matches the contextual filter is returned. No nesting. There's no indication of multiple parameters whatsoever. Easy enough to workaround. Just need to assume you've got the entity if the |
PR incoming.. |
by the time i've figured it out @seth-shaw-unlv already has a PR lol |
yup yup yup! i can attest that it works! (of course, it only works on vocabularies that you configure to have the gemini URI in the Islandora config. Just a reminder, because... i was confused for a second. 😅) |
The Fedora URI (or Gemini URI, depending on which part of the interface you're in) can be configured to show up on Taxonomy Terms. However, it does not display.
I am looking, for example, at the built-in terms that come with the playbook, e.g. Software (part of Resource Types), which in my box is at /taxonomy/term/12.
In Gemini, via SQL, i can verify that it has a Fedora URI.
However, despite
No Fedora URI appears.
In my Drupal Recent Log Messages, there is a 'Gemini findByURI 404 response'.
The text was updated successfully, but these errors were encountered: