Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading islandora_image form replaces the OBJ field #664

Closed
Natkeeran opened this issue Jun 14, 2017 · 12 comments
Closed

Reloading islandora_image form replaces the OBJ field #664

Natkeeran opened this issue Jun 14, 2017 · 12 comments

Comments

@Natkeeran
Copy link
Contributor

Natkeeran commented Jun 14, 2017

Steps to reproduce

  • Go to Add Content and create an Islandora Image node http://localhost:8000/node/add/islandora_image
  • Enter the title
  • Reload the page
  • Click Add new media for OBJ
  • (OBJ field seems to disappear)

The above steps consistently reproduces the issue.

  • Seems like a more basic problem. When trying to create media for OBJ, it fails with the message "Only files with the following extensions are allowed: jp2."

I have the following committ:

commit 20ce269ae52b215a0eb7b673bddbd0833a610d69
Author: Nick Ruest <ruestn@gmail.com>
Date:   Tue Jun 13 09:24:29 2017 -0400

Expected behavior

  • Should allow the user to enter the OBJ.

The actual, incorrect behavior

  • OBJ field seems to disappear.
@Natkeeran
Copy link
Contributor Author

islandora_image_obj_issue

@whikloj
Copy link
Member

whikloj commented Jun 14, 2017

@Natkeeran did you save between steps 2 and 3? I have not been able to replicate this, but I'm not sure I am following the steps correctly.

@whikloj
Copy link
Member

whikloj commented Jun 14, 2017

@Natkeeran also what is the commit you are referencing from? I can't find that commit in islandora_image

@MarcusBarnes
Copy link

I've been able to reproduce afterall. First make sure you create a collection. Then create a Islandora Image via "Add content". The initial message under the OBJ section is "Allowed types: png gif jpg jpeg tiff tif jp2 bmp." Under "2M limit". After refresh the message says "Allowed types: jp2." Trying to add a .tiff file under 2MB after the refresh fails.

@whikloj
Copy link
Member

whikloj commented Jun 14, 2017

@MarcusBarnes ok so you:

  1. Create an Islandora Collection
  2. Fill out the title and save/publish the collection.
  3. Create the Islandora Image
  4. You don't need to populate any fields in the Islandora Image, or you do?
  5. You don't save the Islandora Image, or you do?
  6. Hit the browser refresh button and then the OBJ media field allowed extension changes?

Is that correct?

@Natkeeran
Copy link
Contributor Author

@whikloj That's the claw vagrant commit. Below is the islandora_image commit.

commit e0fab4a794f4a52cccadad3b3a04de95a43e192f
Author: dannylamb <dlamb@islandora.ca>
Date:   Thu Jun 1 08:37:06 2017 -0300

    Images using nodes (#14)

@MarcusBarnes
Copy link

@whikloj You should see the change to the OBJ section of the form by reloading the page in your browser before saving. It's hard to see, but then if you try to add other file types (such as .tiff or .png in @Natkeeran case) under the size limit, you get an error message.

@whikloj
Copy link
Member

whikloj commented Jun 14, 2017

@Natkeeran @MarcusBarnes thanks, ok I'll see if I can replicate it too.

@Natkeeran
Copy link
Contributor Author

@whikloj Possibly related. After vagrant halt and up, activemq does not seem to start up (i.e http://localhost.com:8161/admin/ not available). Thus, when creating new objects, 'Could not connect to a broker (Host: localhost)' error gets thrown.

@whikloj
Copy link
Member

whikloj commented Jun 14, 2017

@Natkeeran not sure if that is related. I think the issue is around the ajax calls. Here is how I messed it up.

  1. I clicked Create Media on OBJ.
  2. I clicked Create Media on JP2.
  3. I started to upload a large (39MB) JP2 to the JP2 entity. (I upped the max file size to 2GB)
  4. I clicked Cancel on the OBJ.

The OBJ seemingly should cancel quickly, but instead it hangs around until the JP2 ajax request is completed and the reason is......

claw_inline_error

Looks like it is mixing up the various media_entities. This is probably a problem with the inline_media_entity module

@whikloj
Copy link
Member

whikloj commented Jun 14, 2017

Just to make it absolutely clear it has returned to the wrong location, I clicked Remove on the top one and Create media on the second one and got.

claw_inline_error2

@Natkeeran Natkeeran added the bug label Jan 30, 2018
dannylamb pushed a commit to dannylamb/CLAW that referenced this issue Feb 8, 2018
Not all step based ingest workflows required to have a parent
COLLECTION object. Even when it’s common, there are concrete cases,
like newspapers and books, where the parent object is not a collection.
And more over, it does not require such because the resulting ingested
object are not children of such. This pull request fixes an error
introduced by a recent pull which enabled Contextual CMODEL labels on
step forms and broke book and newspaper drupal tests. Also adds the
ability to enable/disable those contextual messages since the use case
could not be global.
@dannylamb
Copy link
Contributor

Resolved via a1987ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants