-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reloading islandora_image form replaces the OBJ field #664
Comments
@Natkeeran did you save between steps 2 and 3? I have not been able to replicate this, but I'm not sure I am following the steps correctly. |
@Natkeeran also what is the commit you are referencing from? I can't find that commit in |
I've been able to reproduce afterall. First make sure you create a collection. Then create a Islandora Image via "Add content". The initial message under the OBJ section is "Allowed types: png gif jpg jpeg tiff tif jp2 bmp." Under "2M limit". After refresh the message says "Allowed types: jp2." Trying to add a .tiff file under 2MB after the refresh fails. |
@MarcusBarnes ok so you:
Is that correct? |
@whikloj That's the claw vagrant commit. Below is the islandora_image commit.
|
@whikloj You should see the change to the OBJ section of the form by reloading the page in your browser before saving. It's hard to see, but then if you try to add other file types (such as .tiff or .png in @Natkeeran case) under the size limit, you get an error message. |
@Natkeeran @MarcusBarnes thanks, ok I'll see if I can replicate it too. |
@whikloj Possibly related. After vagrant halt and up, activemq does not seem to start up (i.e http://localhost.com:8161/admin/ not available). Thus, when creating new objects, 'Could not connect to a broker (Host: localhost)' error gets thrown. |
@Natkeeran not sure if that is related. I think the issue is around the ajax calls. Here is how I messed it up.
The OBJ seemingly should cancel quickly, but instead it hangs around until the JP2 ajax request is completed and the reason is...... Looks like it is mixing up the various media_entities. This is probably a problem with the inline_media_entity module |
Not all step based ingest workflows required to have a parent COLLECTION object. Even when it’s common, there are concrete cases, like newspapers and books, where the parent object is not a collection. And more over, it does not require such because the resulting ingested object are not children of such. This pull request fixes an error introduced by a recent pull which enabled Contextual CMODEL labels on step forms and broke book and newspaper drupal tests. Also adds the ability to enable/disable those contextual messages since the use case could not be global.
Resolved via a1987ae |
Steps to reproduce
http://localhost:8000/node/add/islandora_image
The above steps consistently reproduces the issue.
I have the following committ:
Expected behavior
The actual, incorrect behavior
The text was updated successfully, but these errors were encountered: