Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claw-playbook: drush version issues #784

Open
Natkeeran opened this issue Jan 25, 2018 · 8 comments
Open

claw-playbook: drush version issues #784

Natkeeran opened this issue Jan 25, 2018 · 8 comments
Labels
Subject: Ansible Playbook Related to the maintenance and upkeep associated with an Ansible Playbook for Islandora. Always also

Comments

@Natkeeran
Copy link
Contributor

It seems that claw-playbook gets the latest drush version. The command and syntax changes considerably between drush versions. For instance, this #783 and related issues are caused by this change. Should we fix the drush version for a given duration, and then do a cyclic updates to drush?

@DigitLib
Copy link

@Natkeeran what version you get? I have on CentOS 8.1.10

@Natkeeran
Copy link
Contributor Author

@DigitLib I get drush 9.0

@whikloj
Copy link
Member

whikloj commented Jan 29, 2018

This makes sense and seems like an easy fix by adding drush_version: x.x.x exactly matching the drush release version we want to the claw-playbook group_vars files.

@DigitLib
Copy link

I started an fresh Ubuntu version today and get 8.1.10 version...

@whikloj
Copy link
Member

whikloj commented Jan 29, 2018

I'm wondering about this PR. @seth-shaw-unlv should we make a PR to "pin" the drush version before we run your PR through?

Regardless I think this is a good idea, even if we aren' noticing differences between systems I think pinning the version would save us from having the ground shift underneath us.

I can open a quick PR to pin drush at 8.1.10.

@seth-shaw-unlv
Copy link
Contributor

I have no preference which drush version we use (I just want it to work). I think pinning it so it doesn't keep moving around makes sense.

@whikloj
Copy link
Member

whikloj commented Jan 30, 2018

I'm adding this work to this PR (Islandora-Devops/islandora-playbook#52), just running a quick test then I'll update it.

@whikloj
Copy link
Member

whikloj commented Jan 30, 2018

I am not adding this to the above PR-52. Why? Let me tell you....

By default the geerlingguy.drush role uses drush-launcher which seems to self-update which explains why we seem to get the latest version when using it.

So I am looking at switching to the composer install method which allows us to use the drush_composer_version: variable to restrict the version (using composer constraints which is nice).

The other alternative is the source install, it uses drush_install_source_version:.

I'm not even sure where I saw drush_version: now...maybe I dreamt it.

@kstapelfeldt kstapelfeldt added Subject: Ansible Playbook Related to the maintenance and upkeep associated with an Ansible Playbook for Islandora. Always also and removed Ansible labels Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: Ansible Playbook Related to the maintenance and upkeep associated with an Ansible Playbook for Islandora. Always also
Projects
Development

No branches or pull requests

5 participants