Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing RDF Mappings #990

Closed
dannylamb opened this issue Dec 19, 2018 · 9 comments
Closed

Missing RDF Mappings #990

dannylamb opened this issue Dec 19, 2018 · 9 comments

Comments

@dannylamb
Copy link
Contributor

RDF Mappings for the following vocabularies are missing:

  • islandora_access
  • islandora_display
  • resource_types

Copy/paste existing ones and edit/rename as appropriate.

@dannylamb
Copy link
Contributor Author

Testing instructions:

Go to the jsonld representation for a resource_type like Collection. View it's ?_format=jsonld page and you'll see just '@idand@type`. For me it was http://localhost:8000/taxonomy/term/2?_format=jsonld

Then vagrant ssh into your instance and do the following:

  • cd /var/www/html/drupal/web/modules/contrib/islandora
  • sudo git checkout -b dannylamb-missing-rdf-mappings 8.x-1.x
  • sudo git pull https://github.com/dannylamb/islandora.git missing-rdf-mappings
  • cd /var/www/html/drupal/web/modules/contrib/islandora_demo
  • sudo git checkout -b dannylamb-missing-rdf-mappings 8.x-1.x
  • sudo git pull https://github.com/dannylamb/islandora_demo.git missing-rdf-mappings
  • cd /var/www/html/drupal/web/modules/contrib/controlled_access_terms
  • sudo git checkout -b dannylamb-missing-rdf-mappings 8.x-1.x
  • sudo git pull https://github.com/dannylamb/controlled_access_terms.git missing-rdf-mappings
  • drush -y fim islandora_core_feature,islandora_demo,controlled_access_terms_default_configuration
  • drush cr

Now revisit the url (might have to ctrl+shift+r to clear the browser cache), and you should see the name and description.

@mjordan
Copy link
Contributor

mjordan commented Dec 19, 2018

I'll test later today.

@mjordan
Copy link
Contributor

mjordan commented Dec 20, 2018

Tested using http://localhost:8000/taxonomy/term/1?_format=jsonld (Open Seadragon from the islandora_display vocabulary):

Before:

before

After:

after

But, my islandora_access vocabulary is empty (on two recently built VMs), and when I attempt to add the first term to it, the "Add" form is not showing any RDF mapping fields:

add

Is that expected?

@dannylamb
Copy link
Contributor Author

@mjordan I'm not exactly sure what you mean by

the "Add" form is not showing any RDF mapping fields

islandora_access is there, but we don't do anything to it and leave it up to the user to customize. It's essentially a freshly minted vocabulary. It's like that because we couldn't come up with a default use case that didn't feel contrived. But name and description and modified date should get mapped to rdf like the other vocabs.

@mjordan
Copy link
Contributor

mjordan commented Dec 20, 2018

I was referring to the External URI field that the other vacabs have, e.g.:

xternaluri

Which makes sense, since the Islandora Access vocab doesn't have that field defined.

@dannylamb
Copy link
Contributor Author

@mjordan There were thoughts about whether or not we islandora_access needed an external_uri, because it seemed like it should. But we came to the conclusion of leaving it out until we confirmed it was neccessary.

@mjordan
Copy link
Contributor

mjordan commented Dec 21, 2018

Makes sense. Do you want me to do any more testing on this?

@dannylamb
Copy link
Contributor Author

@mjordan I think this is good to go.

@seth-shaw-unlv
Copy link
Contributor

Resolved via linked PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants