Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address #157 - Update IslandoraSync to use a configurable activeMQ br… #158

Merged
merged 4 commits into from
Mar 9, 2016
Merged

Address #157 - Update IslandoraSync to use a configurable activeMQ br… #158

merged 4 commits into from
Mar 9, 2016

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Feb 22, 2016

…oker url.

@ruebot
Copy link
Member Author

ruebot commented Feb 22, 2016

@daniel-dgi ready for review.

...and this should help out @nigelgbanks.

@ruebot ruebot mentioned this pull request Feb 22, 2016
Closed
daniel-dgi
daniel-dgi reviewed Feb 22, 2016
View reviewed changes
camel/sync/src/main/resources/OSGI-INF/blueprint/blueprint.xml
@@ -34,4 +34,9 @@
<routeContextRef ref="drupalAuthentication"/>
</camelContext>

<!-- configuration of activemq component -->
<bean id="activemq" class="org.apache.activemq.camel.component.ActiveMQComponent">
<property name="islandora.brokerUrl" value="${jms.islandora.brokerUrl}"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just islandora.brokerUrl here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to add a cm:property tag around line 17

@nigelgbanks
Copy link
Member

Awesome thanks! On a side note I setup a container with SSH and tunnelled the JMS port so it looked like it was coming from local host fooled cURL, but I still couldn't get everything working. So... I build a kitchensink container with all of our dependancies in the same container (Fedora got updated but Drupal did not get fedora properties synced back into it). I'm still digging though but this should help me test the non-kitchen sink version.

@ruebot
Copy link
Member Author

ruebot commented Feb 22, 2016

@daniel-dgi pushed updates

@whikloj whikloj self-assigned this Mar 2, 2016
whikloj
whikloj reviewed Mar 3, 2016
View reviewed changes
camel/sync/src/main/cfg/ca.islandora.sync.cfg
@@ -5,3 +5,4 @@ islandora.fcrepo.baseurl = localhost:8080/fcrepo/rest
islandora.php.workingDir = /home/vagrant/islandora/camel/commands/bin
islandora.php.executable = islandora.php
islandora.triplestore.baseurl = localhost:8080/bigdata/namespace/kb/sparql
islandora.brokerUrl = localhost:61616
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be tcp://localhost:61616

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh. updating now.

@ruebot
Copy link
Member Author

ruebot commented Mar 3, 2016

@whikloj updated 😄

@whikloj
Copy link
Member

whikloj commented Mar 3, 2016

This should work, but I get

2016-03-03 20:26:31,383 | ERROR | rint Extender: 3 | BlueprintContainerImpl           | 12 - org.apache.aries.blueprint.core - 1.4.4 | Unable to start blueprint container for bundle ca.islandora.camel.sync.islandora-sync-gateway/0.0.1.SNAPSHOT
org.osgi.service.blueprint.container.ComponentDefinitionException: Unable to find property descriptor brokerUrl on class org.apache.activemq.camel.component.ActiveMQComponent
        at org.apache.aries.blueprint.container.BeanRecipe.getPropertyDescriptor(BeanRecipe.java:952)[12:org.apache.aries.blueprint.core:1.4.4]
        at org.apache.aries.blueprint.container.BeanRecipe.setProperty(BeanRecipe.java:934)[12:org.apache.aries.blueprint.core:1.4.4]

I compared it to one of @acoburn's blueprint.xml files and it looks the same.

So either Aries or Camel or something is screwing up, but at this point I'm ready to toss the whole lot in favour of never using OSGi again.

Who wants next?

@DiegoPino
Copy link
Contributor

@whikloj, what about trying with brokerURL as parameter for ActiveMQ instead of brokerUrl
Maybe is that what this error says?
Unable to find property descriptor brokerUrl on class org.apache.activemq.camel.component.ActiveMQComponent

It's in the docs

http://camel.apache.org/activemq.html

@whikloj
Copy link
Member

whikloj commented Mar 4, 2016

Diego is (of course) right.

But I still can't get this to run properly. Between the Blueprint/OSGi fight that causes getOSGiService() to timeout periodically and (this is a new one to me from the last try) the Islandora services kept re-starting/re-deploying over and over. Maybe due to me changing the getCamelContextCreationTimeout?
I'll try again today.

whikloj
whikloj reviewed Mar 4, 2016
View reviewed changes
camel/sync/src/main/resources/OSGI-INF/blueprint/blueprint.xml
@@ -34,4 +35,9 @@
<routeContextRef ref="drupalAuthentication"/>
</camelContext>

<!-- configuration of activemq component -->
<bean id="activemq" class="org.apache.activemq.camel.component.ActiveMQComponent">
<property name="brokerUrl" value="${islandora.brokerUrl}"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mea culpa @ruebot, this should be <property name="brokerURL" value="${islandora.brokerUrl}"/>

Why I am not a good proof-reader.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH!

@ruebot
Copy link
Member Author

ruebot commented Mar 4, 2016

@whikloj @DiegoPino updated again 😄

@DiegoPino
Copy link
Contributor

@ruebot @whikloj we are having travis errors. OSGI?
I see [INFO] Islandora Basic Image Service ...................... FAILURE [ 46.303 s] maybe harmless but not sure

@ruebot
Copy link
Member Author

ruebot commented Mar 5, 2016

@DiegoPino just needed to restart them. Fine now.

@whikloj
Copy link
Member

whikloj commented Mar 5, 2016

Yeah that is probably the getRoutesTest it fails randomly due to some issue in the CamelBlueprintHelper.getOsgiService(). Hopefully we can figure out why it fails or dump these tests when we move to PHP microservices.

whikloj added a commit that referenced this pull request Mar 9, 2016
@whikloj
Merge pull request #158 from ruebot/157
d20d19c 
Address #157 - Update IslandoraSync to use a configurable activeMQ br…
@whikloj whikloj merged commit d20d19c into Islandora:7.x-2.x Mar 9, 2016
@ruebot ruebot deleted the 157 branch March 9, 2016 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@whikloj whikloj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ruebot @nigelgbanks @whikloj @DiegoPino @daniel-dgi