Giving Milline a proper api and not just accepting event messages who… #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| $this->log->debug("YOU GET HERE YET?"); |
There was a problem hiding this comment.
We might want to take that line out or make it a proper message.
dannylamb
commented
Jul 27, 2018
Milliner/src/app.php
Outdated
| $app->post('/media', "milliner.controller:saveMedia"); | ||
| $app->post('/file', "milliner.controller:saveFile"); | ||
| $app->delete('/resource/{uuid}', "milliner.controller:delete"); | ||
| $uuid_regex = "/^[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i"; |
There was a problem hiding this comment.
I can get rid of this, too, i think.
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=============================================
+ Coverage 55.03% 65.32% +10.28%
+ Complexity 123 86 -37
=============================================
Files 5 5
Lines 645 421 -224
=============================================
- Hits 355 275 -80
+ Misses 290 146 -144
Continue to review full report at Codecov.
|
whikloj
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lesale
GitHub Issue: Part of Islandora/documentation#769
What does this Pull Request do?
Updates Crayfish to work with the new Flysystem changes.
What's new?
How should this be tested?
Test as part of Islandora/documentation#92
Interested parties
@Islandora-CLAW/committers