Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Chullo with Fedora API Spec #60

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Mar 31, 2017

GitHub Issue: Islandora/documentation#581

What does this Pull Request do?

  • Remove COPY
  • Remove MOVE
  • Remove Transactions (Atomic Batch Operations)
  • Remove UUID
  • Update tests
  • Update TravisCI configuration
  • Update README

What's new?

Whole lot of stuff removed to align with fcrepo API-Specification efforts.

How should this be tested?

Our tests should cover us here.

Interested parties

@dannylamb

* Remove COPY
* Remove MOVE
* Remove Transactions (Atomic Batch Operations)
* Remove UUID
* Update tests
* Update TravisCI configuration
* Update README
@codecov
Copy link

codecov bot commented Mar 31, 2017

Codecov Report

Merging #60 into master will decrease coverage by 10.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #60       +/-   ##
===========================================
- Coverage   92.79%   82.48%   -10.32%     
===========================================
  Files           4        3        -1     
  Lines         222      137       -85     
===========================================
- Hits          206      113       -93     
- Misses         16       24        +8
Impacted Files Coverage Δ
src/Chullo.php 92.06% <ø> (-4.78%) ⬇️
src/FedoraApi.php 71.64% <ø> (-16.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd04f51...ea208ad. Read the comment docs.

@dannylamb dannylamb merged commit 9927a11 into Islandora:master Mar 31, 2017
@ruebot ruebot deleted the issue-581-redux branch March 31, 2017 16:38
ruebot added a commit to yorkulibraries/chullo that referenced this pull request Mar 31, 2017
* Remove the remainder of transactions
* Follow-up to Islandora#60
* Also addresses Islandora/documentation#581
@ruebot ruebot mentioned this pull request Mar 31, 2017
dannylamb pushed a commit that referenced this pull request Apr 3, 2017
* Remove the remainder of transactions
* Follow-up to #60
* Also addresses Islandora/documentation#581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants