Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define token for linked-agent #30

Closed
wants to merge 1 commit into from
Closed

Define token for linked-agent #30

wants to merge 1 commit into from

Conversation

kayakr
Copy link
Contributor

@kayakr kayakr commented Jun 19, 2019

e.g. [node:linked-agent:cre] for use in metatag module.

e.g. [node:linked-agent:cre] for use in metatag module.
@kayakr
Copy link
Contributor Author

kayakr commented Jun 19, 2019

Not sure this should be here, or whether Linked Agent would be best pulled out to be its own module...

@seth-shaw-unlv
Copy link
Contributor

@kayakr, this looks like the appropriate place for it, although I haven't used tokens, so I'm not sure I'm the best person to test. Also, can you click that "update branch" button? Thanks.

@seth-shaw-unlv
Copy link
Contributor

@kayakr, I'm sorry this PR has languished unreviewed for so long! It looks like the repo it was based on was deleted so Travis won't work with it any more. Do you want to resubmit it and I'll give it a go?

@elizoller elizoller mentioned this pull request Apr 28, 2021
@kayakr
Copy link
Contributor Author

kayakr commented May 17, 2021

@seth-shaw-unlv This work has been overtaken by PR #66 but I wonder if you know why Typed Relation fields don't generate the same same tokens as normal Entity reference fields do, even though TypedRelation extends EntityReferenceItem? It seems like there is some default entity api goodness that TypedRelation isn't using.
For Entity reference fields like Repository Item Model, the token browser traverses the relationship and allows use of fields on the taxonomy term but this doesn't happen for Linked Agent mapping to (say) Person vocabulary.

@seth-shaw-unlv
Copy link
Contributor

@kayakr , honestly, 🤷‍♂️. I have no experience with tokens other than using them once or twice... so I don't know why it isn't working.

@kayakr
Copy link
Contributor Author

kayakr commented May 21, 2021

@seth-shaw-unlv Fair enough. I'd like to see it working but it requires more knowledge of the Entity API than I have at present...

@kayakr
Copy link
Contributor Author

kayakr commented Jul 18, 2021

Closing in favour of tokens added via Islandora/documentation#1171 (comment)

@kayakr kayakr closed this Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants