Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up pull #167

Merged
merged 2 commits into from
Mar 19, 2016
Merged

Conversation

nigelgbanks
Copy link
Member

Replaced hardcoded url's with variable calls.

// Try to connect to the server.
$url = $element['#value'] . '/cxf';
$handle = curl_init($url);
curl_setopt($handle, CURLOPT_RETURNTRANSFER, TRUE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis is failing due to 2 spaces between $handle, and CURLOPT_RETURNTRANSFER.

@whikloj
Copy link
Member

whikloj commented Mar 18, 2016

@nigelgbanks why did you close the other pull request (#166)?

@nigelgbanks
Copy link
Member Author

Just to clean up.

@whikloj
Copy link
Member

whikloj commented Mar 18, 2016

@nigelgbanks oh ok, if you want we can always squash your commits before merging it in. Your call.

@whikloj
Copy link
Member

whikloj commented Mar 18, 2016

Testing now...

@whikloj
Copy link
Member

whikloj commented Mar 19, 2016

Sorry for the delay, didn't get finished before the end of the day. Tested and this works for me. Merging in an hour if I don't hear from anyone.

@DiegoPino
Copy link
Contributor

👍 looks fine. You are good to go and you can merge @whikloj

@ruebot
Copy link
Member

ruebot commented Mar 19, 2016

THUMB
On Mar 19, 2016 5:00 PM, "Diego Pino Navarro" notifications@github.com
wrote:

[image: 👍] looks fine. You are good to go and you can merge @whikloj
https://github.com/whikloj


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#167 (comment)

whikloj added a commit that referenced this pull request Mar 19, 2016
@whikloj whikloj merged commit eefb6a0 into Islandora:7.x-2.x Mar 19, 2016
@nigelgbanks nigelgbanks deleted the 7.x-2.x-remove-hardcoded-urls branch March 20, 2016 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants