-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RDF mapping of field_weight as co:index (Issue 1262) #9
Add RDF mapping of field_weight as co:index (Issue 1262) #9
Conversation
Testing now |
Any reason why we can't bring the code over into the main islandora module? The view would have to stay because it references the weight field, but everything else could just hop on over. And also... it works. I should mention that. |
We could, but the code is pointless without the weight field to make use of it.... Let me know if you would prefer I bring it over to islandora and I will whip-up a PR. |
My understanding is that this would work with anything that uses an integer field for sorting and wants to make a view. If the code lives in Also, I'm missing something. Where does the submit button on the view come from? I see the submit function in the code, but can't find where the button comes from. |
Okay, I make the PR on the islandora module this morning. If I understand it correctly (which I may not), the save button comes gratis with drupal_attach_tabledrag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
GitHub Issue: Islandora/documentation/issues/1262
Replaces #6
What does this Pull Request do?
Creates a "Reorder Children" view/tab using the integer_weight_selector provided by the accompanying PR.Adds an RDF mapping of field_weight as co:index. ('cause everything else in this PR is moving to core: Islandora/documentation/pull/171)
What's new?
(ie. Regeneration activity, etc.)? Re-index for weight values to appear.
How should this be tested?
Additional Notes:
Although we talked about replacing the 'purl.org/co/index' with 'schema:position', integers are serialized with the type
http://www.w3.org/2001/XMLSchema#int
; which Google's structured data tester did not like. So, at least for now, we should keep the 'co:index' property until we decide if trying to rewrite Drupal integer types as 'schema:Integer'.Interested parties
@dannylamb, @Islandora-CLAW/committers