Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grok dependency #62

Closed
wants to merge 2 commits into from

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Apr 6, 2018

Updates the Grok dependency to the new "works with Centos" version.

Please test with both Ubuntu and Centos. Though Centos will probably fail once you get past Grok 😄

@whikloj
Copy link
Member Author

whikloj commented Apr 30, 2018

@dannylamb @jonathangreen @Natkeeran could someone look at this.

Deploying claw-playbook on non-Ubuntu is still non-existant.
Islandora/documentation#809 (comment)

@ajs6f
Copy link
Contributor

ajs6f commented Apr 30, 2018

Don't know how useful this is, but on a CentOS box I'm getting:

TASK [Islandora-Devops.grok : Cmake grok] **************************************************************************************************
Monday 30 April 2018  16:31:31 -0400 (0:00:00.977)       0:15:39.442 **********
fatal: [default]: FAILED! => {"changed": true, "cmd": ["cmake", "../"], "delta": "0:00:00.023255", "end": "2018-04-30 16:31:32.214446", "msg": "non-zero return code", "rc": 1, "start": "2018-04-30 16:31:32.191191", "stderr": "CMake Error at CMakeLists.txt:10 (cmake_minimum_required):\n  CMake 3.1 or higher is required.  You are running version 2.8.12.2", "stderr_lines": ["CMake Error at CMakeLists.txt:10 (cmake_minimum_required):", "  CMake 3.1 or higher is required.  You are running version 2.8.12.2"], "stdout": "-- Configuring incomplete, errors occurred!", "stdout_lines": ["-- Configuring incomplete, errors occurred!"]}

I will investigate further-- could be some chain of versions of dependencies going wrong?

@ajs6f
Copy link
Contributor

ajs6f commented May 10, 2018

Okay, I was able to get past my fail above by installing cmake3 and changing this line to use cmake3, but now I'm exploding in flames in the next step (make) like this.

Starting to wonder if I can't just get away with disabling Grok...

@ajs6f
Copy link
Contributor

ajs6f commented May 10, 2018

Hang on, I've done something wrong here-- I think I'm running parts of the Ansible play without this PR, and parts with. Or something like that.

@ajs6f
Copy link
Contributor

ajs6f commented May 10, 2018

Yep, I needed to manually ansible-galaxy install --force Islandora-Devops.grok,0.0.2. :sigh:

@ajs6f
Copy link
Contributor

ajs6f commented May 10, 2018

Okay, after further investigation, it is clear that Grok fails to build under any condition on CentOS7 (with something like this), so this isn't a CLAW issue per se, it's upstream. I'm going to open a new ticket about this, because it is apparently CentoOS-specific (since other people are able to use this PR).

@ajs6f
Copy link
Contributor

ajs6f commented May 10, 2018

The last comment is WRONG WRONG WRONG. See Islandora/documentation/issues/809 for the TRUTH.

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@seth-shaw-unlv
Copy link
Contributor

Anyone else, @Islandora-Devops/committers, want to review this before we merge?

@jonathangreen
Copy link
Contributor

@seth-shaw-unlv if your comfortable with the changes, go for it!

@seth-shaw-unlv
Copy link
Contributor

Covered by #68.

@whikloj whikloj deleted the grok-requirements branch June 22, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants