Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playbook is setting configs that it shouldn't and is skipping setting configs. #248

Open
rosiel opened this issue Jan 12, 2023 · 1 comment

Comments

@rosiel
Copy link
Contributor

rosiel commented Jan 12, 2023

There's a whole section of the post-install.yml file that does drush cset commands (config set). If I understand correctly, these are a holdover from when we had Defaults, which potentially didn't include setting these config variables. This includes setting Media to have standalone URLs and whether we should remove ?_format=jsonld.

We now have a place for these Config decisions to go (starter site, and also install profile).

There are also a handful of variables that need to match the environment, such as the location of cantaloupe or fedora or whatnot. The values currently used in the Starter Site are values that will work with the playbook. However, it'd be good form for the Playbook to set these.

  • remove these where they are already set in the starter site, and
  • ensure that all the variables that need to be set by the playbook are being set by the playbook.
@rosiel
Copy link
Contributor Author

rosiel commented Jan 16, 2023

This has become a bit of a cleaning exercise regarding the use of Drush in the Playbook.

We can remove these from post-install.yml, because they're part of the starter site

    - name: Set JSONLD Config
      command: "{{ drush_path }} --root {{ drupal_core_path }} -y cset --input-format=yaml jsonld.settings remove_jsonld_format {{ drupal_jsonld_remove_format }}"

    - name: Set media urls
      command: "{{ drush_path }} --root {{ drupal_core_path }} -y cset --input-format=yaml media.settings standalone_url true"
[...]
    - name: Set iiif manifest view
      command: "{{ drush_path }} --root {{ drupal_core_path }} -y cset --input-format=yaml openseadragon.settings manifest_view iiif_manifest"

We do need to set these (but could rename to be clearer)

    - name: Set iiif url
      command: "{{ drush_path }} --root {{ drupal_core_path }} -y cset --input-format=yaml islandora_iiif.settings iiif_server {{ openseadragon_iiiv_server }}"

    - name: Force Alpaca host setting to override install profile.
      command: "{{ drush_path }} --root {{ drupal_core_path }} -y -l localhost:{{ apache_listen_port }} cset islandora.settings broker_url tcp://{{ hostvars[groups['alpaca'][0]].ansible_host }}:61613"

Things we need to set but are not in post-install.yml:

Matomo

  • in roles/internal/webserver-app/tasks/drupal.yml.
  • hardcodes localhost and site_id = 1

Solr

  • in roles/internal/webserver-app/tasks/solr.yml
  • sets the solr host value, and the core to "the first core" (interesting in case someone's doing multisite)

Also using Drush:

  • The Bartik theme is being enabled in roles/internal/webserver-app/tasks/jwt.yml
  • a single JWT-related config file is being loaded (ibid)
  • the core search module is being uninstalled in roles/internal/webserver-app/tasks/drupal.yml
  • we fim (feature import) islandora_core_feature, islandora_defaults, and islandora_search. (I don't think we should do this) (ibid)

[Edit to add]
roles/internal/Islandora-Devops.drupal-openseadragon/tasks/config.yml sets openseadragon's IIIF server setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant