Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement search highlighting #93

Open
rosiel opened this issue Jun 12, 2023 · 2 comments
Open

Implement search highlighting #93

rosiel opened this issue Jun 12, 2023 · 2 comments
Assignees
@rosiel

Comments

@rosiel
Copy link
Contributor

rosiel commented Jun 12, 2023

Advanced search module[1] now does search highlighting. Put in place the configuration needed to take advantage of this.

[1] digitalutsc/advanced_search@0c2504c
@kylehuynh205
Copy link
Contributor

Hi @rosiel , I have create a PR for this #96. Thanks.

@kylehuynh205
Copy link
Contributor

Hi @rosiel , there is small bug which was left from testing work (https://github.com/digitalutsc/advanced_search/blob/contrib/src/AdvancedSearchQuery.php#L277), then it cause the extra matching "search" in the highlight which has been resolved . Plus the config schema has been added and passed the configuration inspector.

image

@rosiel rosiel self-assigned this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosiel rosiel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rosiel @kylehuynh205