New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYPERCUBE_FCREPO_URL needs updating maybe? #224

Closed

misilot opened this issue May 19, 2022 · 5 comments

Assignees

Labels

hypercube milliner release

Contributor

misilot commented May 19, 2022

aoelschlager on slack pointed out https://github.com/Islandora-Devops/isle-buildkit/blob/main/hypercube/Dockerfile#L33

@dannylamb or @nigelgbanks do you know if this needs to change to :8080 and possibly have http:// prepended to it?

These microservices are a blackbox to me, so not really sure.

Contributor

nigelgbanks commented May 19, 2022

Looks to be dead code:

Remove:

https://github.com/Islandora-Devops/isle-buildkit/blob/main/hypercube/rootfs/etc/confd/templates/config.yaml.tmpl#L6-L7
isle-buildkit/hypercube/Dockerfile

Line 33 in 829ba44

HYPERCUBE_FCREPO_URL=fcrepo/fcrepo/rest \
https://github.com/Islandora-Devops/isle-buildkit/blame/main/hypercube/README.md#L15

Contributor

nigelgbanks commented May 19, 2022

While in there update the docs for milliner MILLINER_FCREPO_URL in the readme doesn't match the Dockerfile.

g7morris self-assigned this

g7morris added release hypercube milliner labels

Contributor

g7morris commented Sep 6, 2022

@nigelgbanks Roger that. Testing this now #241

Contributor

g7morris commented Oct 17, 2022

Updated and tested. Merge when ready

Contributor

nigelgbanks commented Oct 19, 2022

Merged

nigelgbanks closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment