Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move traefik service setup into it's own docker-compose file #43

Closed
g7morris opened this issue Apr 16, 2020 · 6 comments
Closed

Move traefik service setup into it's own docker-compose file #43

g7morris opened this issue Apr 16, 2020 · 6 comments

Comments

@g7morris
Copy link
Contributor

From Islandora-Devops/isle-dc#6

Comment from @nikathone

"Also it might be a good idea to move the traefik service setup in it's own docker-compose file cause ideally they should only be one traefik service per local host."

We should discuss how to do this post-merge.

@g7morris
Copy link
Contributor Author

@dannylamb & @nigelgbanks Do we want to optimize towards this on isle-buildkit?

@g7morris g7morris transferred this issue from Islandora-Devops/isle-dc Jun 11, 2020
@nigelgbanks
Copy link
Contributor

Might be tricky, I think traefik needs access to the bridge network(s) created by docker-compose to properly redirect the traffic, not sure if it's possible to do this. Might be able to "import" the network and set all of the containers in the docker-compose file to use the "imported" network, but then there wouldn't be any isolation, do the same as using the default network everywhere.

@nigelgbanks
Copy link
Contributor

Looks like we can define the network explicitly, but only one: https://docs.traefik.io/providers/docker/#network

@nigelgbanks
Copy link
Contributor

Found an example of the shared network approach: traefik/traefik#3599 (comment)

@nigelgbanks
Copy link
Contributor

Oh reading though the isle-dc repo I think I misunderstood the use case here. There would be two or more docker-compose.yml files in the same folder so they would run under the same network. Or was the intention for it to work across folders?

@nigelgbanks
Copy link
Contributor

This is covered by Islandora-Devops/isle-dc#83, now users can use a single traefik instance and spin up multiple environments, where can control traefik via INCLUDE_TRAEFIK_SERVICE

@nigelgbanks nigelgbanks self-assigned this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants