Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up .env and change to sample.env instead with README steps #24

Closed
g7morris opened this issue Apr 16, 2020 · 2 comments
Closed

Clean up .env and change to sample.env instead with README steps #24

g7morris opened this issue Apr 16, 2020 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@g7morris
Copy link
Collaborator

  • Sample .env - Clean up .env and change to sample.env instead
  • add to .gitignore
  • Write up steps for how to do this in README
@g7morris
Copy link
Collaborator Author

g7morris commented Apr 16, 2020

@nikathone Putting your comment from the PR here #6 (comment) so we don't loose sight of it and if you also want to work on this.

"For the sample.env I did update the docker-compose.yml accordingly but only focused on drupal and the mariadb services. The other services are using env-file which point to .env and that doesn't make it easier to know which environment variables they really need. It could be easier for someone who understand how these services work to do the refactoring."

You had one more good comment here #6 (comment)

"One more thing once we have the sample.env and docker-compose.yml environment variables setup we should then get rid of .env, add it to .gitignore and then update the doc."

@nikathone
Copy link
Member

Ok. will wait for the merge to see if I can take a stab at this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants