-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solr does not work on starter
or starter_dev
#305
Comments
Yeah, it appears that configure_islandora_defaults currently only sets search_api. Its actions can probably be rolled into configure_search_api_solr_module. |
Half-tempted to suggest making things more atomic, splitting up the functions between enabling and configuring things, as with the ... really, might be nice to avoid changing the configuration proper with provisioned/environment specifics (as in, that which is imported/exported) in all cases by using Drupal's configuration override mechanism. |
I'm gonna make a new issue for the "avoid changes to configuration" thing. |
@rosiel, okay to close with the merged PR? |
Nope. Needs
|
relevant PR: #308 |
The Solr URL configuration is not being set.
It appears to be because the lines that do this are skipped when you're not using Islandora Defaults.
As far as I can tell, the call stack is:
make starter_dev
(orstarter
) calls (make
)hydrate
make hydrate
calls (make
)update-config-from-environment
make update-config-from-environment
callsconfigure_islandora_default_module
which is a function available in the Drupal container, presumably copied fromisle-buildkit/drupal/rootfs/etc/islandora/utilities.sh
isle-buildkit/drupal/rootfs/etc/islandora/utilities.sh
'sconfigure_islandora_default_module
does the Solr URL config.Is the solution as simple as moving those lines to the function below,
configure_search_api_solr_module
?@seth-shaw-asu @adam-vessey
The text was updated successfully, but these errors were encountered: