Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solr does not work on starter or starter_dev #305

Closed
rosiel opened this issue Oct 28, 2022 · 6 comments
Closed

Solr does not work on starter or starter_dev #305

rosiel opened this issue Oct 28, 2022 · 6 comments

Comments

@rosiel
Copy link
Contributor

rosiel commented Oct 28, 2022

The Solr URL configuration is not being set.

It appears to be because the lines that do this are skipped when you're not using Islandora Defaults.

As far as I can tell, the call stack is:
make starter_dev (or starter) calls (make) hydrate
make hydrate calls (make) update-config-from-environment
make update-config-from-environment calls configure_islandora_default_module which is a function available in the Drupal container, presumably copied from isle-buildkit/drupal/rootfs/etc/islandora/utilities.sh
isle-buildkit/drupal/rootfs/etc/islandora/utilities.sh's configure_islandora_default_module does the Solr URL config.

Is the solution as simple as moving those lines to the function below, configure_search_api_solr_module?

@seth-shaw-asu @adam-vessey

@seth-shaw-asu
Copy link

Yeah, it appears that configure_islandora_defaults currently only sets search_api. Its actions can probably be rolled into configure_search_api_solr_module.

@adam-vessey
Copy link
Contributor

Half-tempted to suggest making things more atomic, splitting up the functions between enabling and configuring things, as with the --existing-config it's somewhat expected that there should be no other modules enabled.

... really, might be nice to avoid changing the configuration proper with provisioned/environment specifics (as in, that which is imported/exported) in all cases by using Drupal's configuration override mechanism.

@rosiel
Copy link
Contributor Author

rosiel commented Nov 1, 2022

I'm gonna make a new issue for the "avoid changes to configuration" thing.

@seth-shaw-asu
Copy link

@rosiel, okay to close with the merged PR?

@rosiel
Copy link
Contributor Author

rosiel commented Nov 3, 2022

Nope. Needs

  • Buildkit release (automatically deploys?)
  • PR on ISLE-DC to use the new release

@rosiel
Copy link
Contributor Author

rosiel commented Nov 4, 2022

relevant PR: #308

@rosiel rosiel closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants