Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semantic versioning for dependencies. #130

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Use semantic versioning for dependencies. #130

merged 3 commits into from
Oct 21, 2021

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Oct 6, 2021

GitHub Issue: Islandora/documentation#1907

This is a replacement for the pull request #129. Thanks @jordandukart for the following composer wizardry, which was used here:

# from Homarus, etc
$ composer require "islandora/chullo:1.2.0 as dev-dev" -W
$ composer require islandora/crayfish-commons:^2
$ composer remove "islandora/chullo"

What does this Pull Request do?

Milliner, Recast, Hypercube and Homarus use semver in their composer.json files. The lock files now (vs the previous PR) only update PSR, crayfish-commons, mbstring and chullo.

NOTE

This pull request does NOT touch the composer requirements for Houdini, which still uses the dev-symfony-flex branch of crayfish commons.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #130 (b56533a) into 2.x (0a54c76) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #130   +/-   ##
=========================================
  Coverage     77.55%   77.55%           
  Complexity      159      159           
=========================================
  Files             6        6           
  Lines           655      655           
=========================================
  Hits            508      508           
  Misses          147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a54c76...b56533a. Read the comment docs.

@whikloj whikloj mentioned this pull request Oct 21, 2021
Merged
@elizoller
Copy link
Member

this seems good at first glance to me, but i'm going to spin up a playbook to double check

@elizoller
Copy link
Member

i see the tests passed on your branch so thats a good thing 👍

@elizoller elizoller self-assigned this Oct 21, 2021
elizoller
elizoller approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@elizoller elizoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i pulled this PR in to a fresh playbook, tested that video derivs got made (homarus), tested that extracted text was generated (hypercube), tested that original files and their metadata made it to fedora (milliner).
i tested recast and although i don't quite understand what the service is supposed to do, it didn't produce any errors so i'll go with its still working.

@elizoller elizoller merged commit ee9ea25 into Islandora:2.x Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizoller elizoller elizoller approved these changes

Assignees

@elizoller elizoller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosiel @elizoller