Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions are not created when using migrations or REST #1485

Open
mjordan opened this issue Apr 12, 2020 · 3 comments
Open

Revisions are not created when using migrations or REST #1485

mjordan opened this issue Apr 12, 2020 · 3 comments
Labels
Subject: Migration Concerning migration from Islandora 7 to Islandora 2.x.x

Comments

@mjordan
Copy link
Contributor

mjordan commented Apr 12, 2020

This is not a bug, it's known behavior of Drupal, but it might take some people by surprise and undercuts all our work on versioning.

The post above says "The node type setting mentioned by the other answers only applies to the node form, it does not affect programatically saved nodes.", and I have confirmed that revisions are indeed not created when nodes are updated using other means such as migrations with the --update flag or via REST PATCH requests.

The thread cited above provides some simple hook_node_presave() code that enables revisions. Given that many people will be updating nodes from CSV via migrations, it might be worth considering implementing a node_presave() hook that will enable revisions on Islandora content types so they can create revisions if they want them.

Pinging @elizoller and other @Islandora/8-x-committers.

@mjordan
Copy link
Contributor Author

mjordan commented Apr 12, 2020

Related issue in Islandora Workbench: mjordan/islandora_workbench#95.

@bseeger
Copy link
Member

bseeger commented Apr 15, 2020

This may or may not be helpful, but posting it here to note it: https://www.drupal.org/project/drupal/issues/2993557

@kstapelfeldt kstapelfeldt added Subject: Migration Concerning migration from Islandora 7 to Islandora 2.x.x and removed migration labels Sep 25, 2021
@rosiel
Copy link
Member

rosiel commented Oct 20, 2021

Tagging meta-issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: Migration Concerning migration from Islandora 7 to Islandora 2.x.x
Projects
Development

No branches or pull requests

4 participants