-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove comments about WebAC #1555
Conversation
WebAC is not used but is listed as a feature added when using Fedora. Although it is there, I'd suggest leaving off of this documentation.
I think that line should stay in since this is giving a view of what Fedora can do, not what Islandora is doing with Fedora. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Shoulda refreshed, didn't see @bseeger 's comments |
@bseeger What about adding comments to indicate that Islandora doesn't leverage this by default? |
@DonRichards I think adding a note that it's not currently leveraged by default in islandora sounds like a good compromise. |
We'll need this PR re-rolled against |
I learned over in Fedora that if you Edit the PR (button at the top), you can change the branch it is against. |
I'm also happy to redo this one as a note instead of a deletion. Your call, @DonRichards |
@manez Sorry I been distracted and didn't see the activity on this PR. Yes I can move it. |
@manez @bseeger @whikloj @dannylamb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @DonRichards !
* Remove comments about WebAC WebAC is not used but is listed as a feature added when using Fedora. Although it is there, I'd suggest leaving off of this documentation. * Update user-intro.md
* Render the example helpful tip properly. (#1586) * Render the example helpful tip properly. * Fix note syntax, again. * Mention the User Call (#1587) * Update rdf-mapping.md doc (#1585) * Update committers.md (#1592) * Fix committer nomination email address (#1593) * Fix old email address. * Update closeCommitterVote.txt * De-CLAW * De-CLAW * DeCLAW * Change email * De-CLAW * Update travis for the main branch switch (#1594) * Master -> Main Rename * Remove comments about WebAC (#1555) * Remove comments about WebAC WebAC is not used but is listed as a feature added when using Fedora. Although it is there, I'd suggest leaving off of this documentation. * Update user-intro.md * Add more details about starting up an islandora. (#1597) * Add more details about starting up an islandora. * Update index.md * Mention use of dev branch for prebuilt base box * Update index.md * Fix typo in VBE * Make clearer the different levels of sandbox reqs. * Update CONTRIBUTING.md (#1601) * Add Jordan to committers list (#1602) * Migration docs updates (#1603) * Added link to newer migration Youtube vid, added migration-overview.md * Replaced used of "*" with "-" for bulleted lists * Updated headings in docs and spelling changes * Main update (#1612) * Render the example helpful tip properly. (#1586) * Render the example helpful tip properly. * Fix note syntax, again. * Update rdf-mapping.md doc (#1585) Co-authored-by: Eli Zoller <5439169+elizoller@users.noreply.github.com> * Merge changes to add @manez to committers. (#1613) * Merge changes to add @manez to committers. * Alphabeticalize committer names. Co-authored-by: dannylamb <dlamb@islandora.ca> * De-CLAWing * Derp * Missing parenthesis Co-authored-by: Rosie Le Faive <lefaive@gmail.com> Co-authored-by: Eli Zoller <5439169+elizoller@users.noreply.github.com> Co-authored-by: Jonathan Green <jonathan.green@lyrasis.org> Co-authored-by: Don Richards <DonRichards@utk.edu> Co-authored-by: Melissa Anez <manez@islandora.ca> Co-authored-by: Yamil <ysuarez@users.noreply.github.com>
WebAC is not used but is listed as a feature added when using Fedora. Although it is there, I'd suggest leaving off of this documentation.
GitHub Issue: None
What does this Pull Request do?
Clarifies documentation on WebAC
What's new?
Doc removing WebAC as a featured added by including Fedora
How should this be tested?
N/A
Additional Notes:
N/A
Interested parties
@Islandora/8-x-committers